fix: adjust to #2658 breaking changes #2688
Conversation
Deploying sanguine-fe with
|
| Latest commit: |
6245d66
|
| Status: | 🚫 Build failed. |
WalkthroughThe changes involve updating the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2688 +/- ##
===================================================
- Coverage 39.76400% 39.36536% -0.39865%
===================================================
Files 185 172 -13
Lines 14576 13362 -1214
Branches 80 119 +39
===================================================
- Hits 5796 5260 -536
+ Misses 8059 7449 -610
+ Partials 721 653 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- packages/contracts-rfq/script/ConfigureFastBridge.s.sol (1 hunks)
- packages/contracts-rfq/script/DeployFastBridge.CREATE2.s.sol (1 hunks)
Additional context used
GitHub Check: codecov/patch
packages/contracts-rfq/script/DeployFastBridge.CREATE2.s.sol
[warning] 34-34: packages/contracts-rfq/script/DeployFastBridge.CREATE2.s.sol#L34
Added line #L34 was not covered by testspackages/contracts-rfq/script/ConfigureFastBridge.s.sol
[warning] 27-27: packages/contracts-rfq/script/ConfigureFastBridge.s.sol#L27
Added line #L27 was not covered by tests
| @@ -31,7 +31,7 @@ | |||
| } | |||
|
|
|||
| function loadConfig() internal { | |||
| string memory config = readGlobalDeployConfig({contractName: NAME, globalProperty: "", revertIfNotFound: true}); | |||
| string memory config = readGlobalDeployConfig({contractName: NAME, environment: "", revertIfNotFound: true}); | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The readGlobalDeployConfig function is defined in packages/solidity-devops/src/reader/DataReader.sol and used in DeployFastBridge.CREATE2.s.sol and ConfigureFastBridge.s.sol. However, there are no tests covering its usage in these files.
packages/contracts-rfq/script/DeployFastBridge.CREATE2.s.solpackages/contracts-rfq/script/ConfigureFastBridge.s.sol
Would you like assistance in writing the necessary tests to cover this change?
Analysis chain
The parameter change from globalProperty to environment aligns with the PR objectives. However, this line is not covered by tests.
Would you like assistance in writing the necessary tests to cover this change?
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if there are tests covering the `readGlobalDeployConfig` function usage in `DeployFastBridge.CREATE2.s.sol`.
# Test: Search for test files and check coverage for the specific function usage.
fd 'test' --type f --exec rg 'readGlobalDeployConfig' {}
Length of output: 56
Script:
#!/bin/bash
# Description: Locate the definition of the `readGlobalDeployConfig` function and its usage across the codebase.
# Step 1: Find the definition of the `readGlobalDeployConfig` function.
ast-grep --lang solidity --pattern 'function readGlobalDeployConfig($_) {}'
# Step 2: Find all usages of the `readGlobalDeployConfig` function across the codebase.
rg 'readGlobalDeployConfig'
Length of output: 649
Script:
#!/bin/bash
# Description: Locate the definition of the `readGlobalDeployConfig` function in `DataReader.sol` and check for tests covering `ConfigureFastBridge.s.sol`.
# Step 1: Find the definition of the `readGlobalDeployConfig` function in `DataReader.sol`.
rg 'function readGlobalDeployConfig' packages/solidity-devops/src/reader/DataReader.sol
# Step 2: Search for test files and check coverage for the `readGlobalDeployConfig` function usage in `ConfigureFastBridge.s.sol`.
fd 'test' --type f --exec rg 'readGlobalDeployConfig' {}
Length of output: 183
Tools
GitHub Check: codecov/patch
[warning] 34-34: packages/contracts-rfq/script/DeployFastBridge.CREATE2.s.sol#L34
Added line #L34 was not covered by tests
| @@ -24,7 +24,7 @@ | |||
| } | |||
|
|
|||
| function loadConfig() internal { | |||
| config = readGlobalDeployConfig({contractName: NAME, globalProperty: "", revertIfNotFound: true}); | |||
| config = readGlobalDeployConfig({contractName: NAME, environment: "", revertIfNotFound: true}); | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The parameter change from globalProperty to environment aligns with the PR objectives. However, there are no tests covering the readGlobalDeployConfig function usage in ConfigureFastBridge.s.sol, DeployFastBridge.CREATE2.s.sol, or the DataReader.sol file where the function is defined.
ConfigureFastBridge.s.sol: No test coverage found.DeployFastBridge.CREATE2.s.sol: No test coverage found.DataReader.sol: No test coverage found.
Would you like assistance in writing the necessary tests to cover this change?
Analysis chain
The parameter change from globalProperty to environment aligns with the PR objectives. However, this line is not covered by tests.
Would you like assistance in writing the necessary tests to cover this change?
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify if there are tests covering the `readGlobalDeployConfig` function usage in `ConfigureFastBridge.s.sol`.
# Test: Search for test files and check coverage for the specific function usage.
fd 'test' --type f --exec rg 'readGlobalDeployConfig' {}
Length of output: 56
Script:
#!/bin/bash
# Description: Search for the `readGlobalDeployConfig` function usage across the entire codebase to identify any indirect test coverage or related usage.
# Search for the function usage in the entire codebase.
rg 'readGlobalDeployConfig'
Length of output: 454
Script:
#!/bin/bash
# Description: Verify if there are tests covering the `DeployFastBridge.CREATE2.s.sol` script.
# Test: Search for test files and check coverage for the specific script usage.
fd 'test' --type f --exec rg 'DeployFastBridge.CREATE2.s.sol' {}
Length of output: 64
Script:
#!/bin/bash
# Description: Verify if there are tests covering the `DataReader.sol` file where `readGlobalDeployConfig` is defined.
# Test: Search for test files and check coverage for the specific file usage.
fd 'test' --type f --exec rg 'DataReader.sol' {}
Length of output: 48
Tools
GitHub Check: codecov/patch
[warning] 27-27: packages/contracts-rfq/script/ConfigureFastBridge.s.sol#L27
Added line #L27 was not covered by tests
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- packages/contracts-rfq/script/ConfigureFastBridge.s.sol (3 hunks)
- packages/contracts-rfq/script/DeployFastBridge.CREATE2.s.sol (3 hunks)
Files skipped from review as they are similar to previous changes (2)
- packages/contracts-rfq/script/ConfigureFastBridge.s.sol
- packages/contracts-rfq/script/DeployFastBridge.CREATE2.s.sol
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
globalPropertytoenvironmentin the FastBridge deployment scripts.