-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rfq-relayer): highly concurrent e2e test #3042
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e995669
WIP: parallel test
dwasse d174bcc
Feat: working serial
dwasse 7afdd4c
Feat: working concurrent requests
dwasse f3ddaf0
Cleanup: revert unnecessary changes
dwasse 5aa0b0c
Cleanup: test name
dwasse a676ca6
Cleanup: lint
dwasse 829e597
Cleanup: lint
dwasse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor to reduce cognitive complexity.
The function
TestMultipleBridges
has a cognitive complexity of 42, which is above the recommended threshold of 30. Consider breaking down the function into smaller, more manageable pieces to improve readability and maintainability.Address the TODO comment for time manipulation.
The comment suggests that the time manipulation logic should be cleaned up. Consider refactoring this part of the code to make it more concise and maintainable.
Remove unnecessary trailing newline.
There is an unnecessary trailing newline at the end of the function. Removing it will improve code cleanliness.
Tools
GitHub Check: Lint (services/rfq)