feat(rfq-api): check both relayer role and quoter role #3398
Conversation
* explorer UI updated * rfq-indexer update * explorer backend update * [goreleaser] trigger explorer version bump * rfq indexer with the right contracts * [goreleaser] adding catch * response error fixes and wld decimals * adding address * feat(rfq-indexer): add `request` column to `BridgeRequested` for refunds (#3287) * feat(rfq-relayer): add MaxRelayAmount (#3259) * Feat: add quoteParams helper for test * Feat: add MaxQuoteAmount to relconfig * Feat: use MaxQuoteAmount * Feat: handle MaxQuoteAmount in quoter test * Replace: MaxQuoteAmount -> MaxRelayAmount * Feat: shouldProcess() returns false if max relay amount exceeded * Feat: add test for MaxRelayAmount * add request field for refunds * adding to events typing --------- Co-authored-by: dwasse <wassermandaniel8@gmail.com> Co-authored-by: defi-moses <jakedinero@protonmail.com> * fix api docs * linting fixes * fixing irrelavent files * wc fixes and tests solved * fix linting errors * [goreleaser] * refining tests * adding bridge Module to graphql * Adding to all bridge watcher queries * adding worldchain to the chart * adding other rfq events to the rfq events db * fixing wld coingecko ticker [goreleaser] * [goreleaser] coingecko update and new topic parsing * small lint fix * [goreleaser] linting fixes * fix(rfq-indexer): add missing fields (#3309) * add missing fields --------- Co-authored-by: abtestingalpha <abtestingalpha@gmail.com> --------- Co-authored-by: vro <168573323+golangisfun123@users.noreply.github.com> Co-authored-by: dwasse <wassermandaniel8@gmail.com> Co-authored-by: abtestingalpha <abtestingalpha@gmail.com>
* feat: start with identical AdminV2 * refactor: refund -> cancel * test: update the tests, add coverage for deprecated method * feat: scaffold `setCancelDelay` * test: coverage for `calcelDelay` management * feat: configurable cancel delay * refactor: custom error `FeeRateAboveMax` * test: chainGasAmount deprecation * feat: deprecate `chainGasAmount` * refactor: drop `UniversalTokenLib` in AdminV2 * refactor: event before external call, docs * relabel RELAYER_ROLE -> PROVER_ROLE * retain RELAYER_ROLE in addtn to PROVER_ROLE, for offchain perms * refactor: RELAYER_ROLE -> QUOTER_ROLE, docs * docs: AdminV2 other constants --------- Co-authored-by: parodime <jordan@protochainresearch.com>
* Feat: call filterQuoteAge() in handlePassiveRFQ() * Feat: refactor into getPassiveQuote() func * Feat: add TestGetPassiveQuote * Config: lower max quote age
dwasse
requested review from
trajan0x,
aureliusbtc,
bigboydiamonds,
abtestingalpha,
Defi-Moses and
ChiTimesChi
as code owners
|
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request involve updates across multiple files, primarily focusing on the introduction of a new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning Rate limit exceeded@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 8 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
services/explorer/graphql/client/queries/queries.graphqlOops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@babel/eslint-parser' declared in '.eslintrc.js': Cannot find module '@babel/core/package.json'
🔧 golangci-lintlevel=warning msg="[config_reader] The configuration option Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
go
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/relayer-arb-call #3398 +/- ##
===============================================================
+ Coverage 26.60645% 26.69992% +0.09346%
===============================================================
Files 214 215 +1
Lines 13617 13633 +16
Branches 82 82
===============================================================
+ Hits 3623 3640 +17
+ Misses 9711 9710 -1
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Changes to gas cost
🧾 Summary (50% most significant diffs)
Full diff report 👇
|
Bundle ReportChanges will decrease total bundle size by 3.83MB (-10.75%) ⬇️. This is within the configured threshold ✅ Detailed changes
ℹ️ *Bundle size includes cached data from a previous commit |
null
913658f: explorer-ui preview link
913658f: synapse-interface preview link
Summary by CodeRabbit
New Features
destAddressandaddress) to API endpoints for enhanced functionality.bridgeModulefor more detailed transaction context.Bug Fixes
Documentation
Chores
@synapsecns/contracts-rfqpackage to include new features and version changes.