Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft limit for maxfiles is NOT increased to the hard one on macOS #6206

Closed
pbrit opened this issue Dec 3, 2019 · 1 comment
Closed

Soft limit for maxfiles is NOT increased to the hard one on macOS #6206

pbrit opened this issue Dec 3, 2019 · 1 comment
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.3.3

Comments

@pbrit
Copy link
Contributor

pbrit commented Dec 3, 2019

Expected behaviour

During the startup, the soft limit for the number of concurrently open files, a.k.a. maxfiles in macOS, is increased up the hard one.

Actual behaviour

During the startup, the soft limit for the number of concurrently open files, a.k.a. maxfiles in macOS, is not increased up to the hard one.

During syncing of large directories, there are many "too many open files errors" on the stdout.

Steps to reproduce

  1. Set the soft limit for maxfiles to an extremely small number (e.g. 30) and the hard one to unlimited
sudo launchctl limit maxfiles 30 unlimited
  1. Start syncthing

Version Information

Syncthing Version: syncthing v1.3.1 "Fermium Flea" (go1.13.4 darwin-amd64)
OS Version: macOS 10.15.1 Catalina
@pbrit
Copy link
Contributor Author

pbrit commented Dec 3, 2019

Related: golang/go#30401

pbrit added a commit to pbrit/syncthing that referenced this issue Dec 3, 2019
@pbrit
cmd/osutil: Increase maxfiles on macOS properly (Fixes syncthing#6206)
67da124
pbrit added a commit to pbrit/syncthing that referenced this issue Dec 3, 2019
@pbrit
cmd/osutil: Increase maxfiles on macOS properly (Fixes syncthing#6206)
3378da9
pbrit added a commit to pbrit/syncthing that referenced this issue Dec 3, 2019
@pbrit
lib/osutil: Increase maxfiles on macOS properly (Fixes syncthing#6206)
ba7e2b2
@calmh calmh closed this as completed in eca156f Dec 3, 2019
@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Dec 3, 2019
calmh added a commit to calmh/syncthing that referenced this issue Dec 4, 2019
@calmh
Merge branch 'master' into badger
e5a6c14 
* master:
  lib: Consistently unsubscribe from config-wrapper (fixes syncthing#6133) (syncthing#6205)
  cmd/ursrv: Show more architectures (fixes syncthing#6211)
  build: Generalize code signing
  lib/osutil: Increase maxfiles on macOS properly (fixes syncthing#6206) (syncthing#6207)
  lib/ignore: Don't create empty ".stignore" files (fixes syncthing#6190) (syncthing#6197)
  lib/db: Remove *instance by making everything *Lowlevel (syncthing#6204)
@calmh calmh added this to the v1.3.3 milestone Dec 5, 2019
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Dec 2, 2020
@syncthing syncthing locked and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.3.3
Development

No branches or pull requests
3 participants
@calmh @pbrit @st-review