fix(utils/smtp): Refactor SMTP pool using gomail.v2 to resolve STARTTLS compatibility issues #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LS compatibility issues - Refactor SMTP connection pool implementation - Optimize pool resource management
zijiren233
requested changes
Dec 16, 2024
# Conflicts: # go.mod
Remove SMTP connection pool in favor of direct connections BREAKING CHANGE: Replace SMTP connection pool with direct connections The SMTP connection pool has been removed in favor of creating new connections for each email send operation. This change: - Removes Pool struct and related code - Adds new Mailer struct for handling email operations - Updates all email sending functions to use new Mailer - Removes pool size configuration - Simplifies connection management Rationale: - SMTP servers often don't handle long-lived connections well - Connection pool adds complexity without significant benefits - Direct connections are more reliable for email sending - Email sending is typically not high-frequency enough to warrant pooling Migration: - Replace getSmtpPool() calls with getMailer() - Update any direct Pool usage to use Mailer instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(utils/smtp): Refactor SMTP pool using gomail.v2 to resolve STARTTLS compatibility issues
原先的实现会在使用部分SMTP提供商的服务时出现
auth failed: SMTP error 504: AUTH LOGIN not supported，因此我使用了更现代的gomail.v2改进了发件部分。代码已分别在一家使用TLS的服务商(ahasend)和一家使用SSL的服务商(阿里云)上通过测试。