Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Update API client connector to use the latest integration runtime #2436

Closed
zregvart opened this issue Apr 19, 2018 · 9 comments · Fixed by #4804
Closed

Update API client connector to use the latest integration runtime #2436

zregvart opened this issue Apr 19, 2018 · 9 comments · Fixed by #4804
Assignees
Labels
cat/feature PR label for a new feature cat/techdebt Label for issues identifying technical debt group/connector Supported camel connectors

Comments

@zregvart
Copy link
Member

This is a...


[x] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

The problem

We don't require auto generated Spring (Boot) configuration classes. Let's remove those from the repository and disable their generation.

@zregvart zregvart added the group/connector Supported camel connectors label Apr 19, 2018
@zregvart zregvart added this to the GA (7.0) milestone Apr 19, 2018
@zregvart zregvart self-assigned this Apr 19, 2018
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Apr 19, 2018
zregvart added a commit to zregvart/syndesis that referenced this issue Apr 19, 2018
This removes `camel-connector-maven-plugin` Maven plugin usage and with
it Spring Boot auto configuration classes that were generated in
`src/main/java`

Fixes syndesisio#2436
@paoloantinori paoloantinori added cat/feature PR label for a new feature and removed notif/triage The issue needs triage. Applied automatically to all new issues. labels Apr 27, 2018
@paoloantinori paoloantinori modified the milestones: GA (7.0), Post GA (7.1) Apr 27, 2018
@heiko-braun heiko-braun modified the milestone: Post GA (7.1) Jun 23, 2018
@stale
Copy link

stale bot commented Sep 21, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Sep 21, 2018
@zregvart zregvart added the cat/techdebt Label for issues identifying technical debt label Sep 24, 2018
@stale stale bot removed the status/stale Issue considered to be stale so that it can be closed soon label Sep 24, 2018
@zregvart
Copy link
Member Author

This is still an issue, we could eliminate code that supports old style connectors and solve build time code generation issues we have.

@lburgazzoli
Copy link
Collaborator

@zregvart do you have any bandwidth to work on this ? afai only the rest-swagger connector is still based on the old style connectors and unfortunately this connector brings spring boot dependencies into the mix which causes troubles for camel-k integration

@zregvart
Copy link
Member Author

zregvart commented Feb 8, 2019

Perhaps next week, not really sure.

@zregvart zregvart added this to the Sprint 42 (3/4) milestone Mar 5, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Mar 6, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Mar 6, 2019
zregvart pushed a commit to zregvart/syndesis that referenced this issue Apr 12, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart pushed a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart pushed a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart pushed a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart pushed a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart pushed a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart pushed a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Apr 15, 2019
@pure-bot pure-bot bot locked as resolved and limited conversation to collaborators Apr 16, 2019
@pure-bot pure-bot bot reopened this Apr 16, 2019
@pure-bot pure-bot bot unlocked this conversation Apr 16, 2019
@mmuzikar
Copy link
Contributor

@zregvart Do you think this could be causing #5250?

@zregvart
Copy link
Member Author

Sure looks like it @mmuzikar. @valdar do you think it would be possible to add a migration so that when importing older Connector model it is migrated to the newest?

@mmuzikar
Copy link
Contributor

@zregvart @valdar is there any conclusion whether the migration will be happening?

@zregvart
Copy link
Member Author

@mmuzikar let's discuss the migration needed for the backward compatibility on #5250

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/feature PR label for a new feature cat/techdebt Label for issues identifying technical debt group/connector Supported camel connectors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants