Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Bump Spring Boot to 1.5.13 #2804

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Bump Spring Boot to 1.5.13 #2804

merged 2 commits into from
Jun 13, 2018

Conversation

chirino
Copy link
Collaborator

@chirino chirino commented Jun 12, 2018

No description provided.

@chirino
Copy link
Collaborator Author

chirino commented Jun 12, 2018

This fixes #2303

@zregvart
Copy link
Member

Seems we're hitting google/error-prone#780 I've triggered a rebuild, not sure if that'll help, if it doesn't we might need to turn off parameter naming check in errorprone by adding -Xep:ParameterName:OFF to compiler arguments.

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pure-bot
Copy link
Contributor

pure-bot bot commented Jun 13, 2018

Pull request approved by @zregvart - applying pr/approved label

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Jun 13, 2018
Our use of Lombok and Errorprone leads to an error[1] when compiling
connectors, as a workaround this disables the name check until this is
resolved in Errorprone.

Fixes syndesisio#2805

[1] google/error-prone#780
@zregvart
Copy link
Member

Now we're getting 403 error when trying to download docker binary, hopefully this will be fixed at get.docker.com and we can retry the build later.

@oscerd
Copy link
Collaborator

oscerd commented Jun 13, 2018

retest this please

@pure-bot pure-bot bot merged commit 8bbd645 into syndesisio:master Jun 13, 2018
@chirino chirino deleted the 2303 branch June 10, 2019 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr/approved Applied by pure-bot when a review is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants