This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
fix(5715,5729) and add empty state components for integration-related components #5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elvisisking
commented
Jun 17, 2019
•
elvisisking
commented
- See NaN duration in the activity log #5715 and Invalid date as Last Processed value in the Metric tab #5729
- added empty state to dashboard's TopIntegrationCard
- added empty state to integrations list
- fixed issues in metrics page when not all metrics are available
- changed data helpers util to return '0 ms' when duration is zero.
…ivity log - added empty state to dashboard's TopIntegrationCard - added empty state to integrations list - fixed issues in metrics page when not all metrics are available - changed data helpers util to return '0 ms' when duration is zero.
pure-bot
bot
added
the
pr/review-requested
|
This is a blocker only Sprint. If this is not related to a corresponding blocker it won't be merged until the end of the sprint or the branching of the code. |
|
@elvisisking can you link this PR to the related issues? |
|
@gashcrumb I've added a link to #5715 in description. The other issue, syndesisio/syndesis-react#427, is from the archived react repo (couldn't get link to work). |
|
Fixed that for ya 😄 |
elvisisking
changed the title
|
@paoloantinori personally I kinda think syndesisio/syndesis-react#427 would be a blocker. |
riccardo-forina
approved these changes
Jun 18, 2019
|
Pull request approved by @riccardo-forina - applying pr/approved label |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.