Add support for specifying Bicep version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since build results will vary across versions this adds the option to specify version. The default version is the latest available version.
To have the shellcheck pass without warnings this adds the disabled flag in the shell file. This change only include configuration for existing warnings and does not change existing shell code to comply with default shellcheck configuration.
Azure CLI is default installed on GitHub runners by default: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#cli-tools This will speed up the action since it does not need to install az if it's already installed.
|
Thanks for making this action - hope you will accept this PR :) Let me know if the other fixes (shellcheck, az handling, set-output syntax) should be separated into another PR - or removed. You can see a test run with the changes here: Action: https://github.com/matsest/bicep-lint-action/actions/runs/4622891173 Please note that this error from the run is an error only found in az 2.46 and is fixed in the newest released version (2.47), so a workaround for it is not added in this PR Azure/azure-cli#25710 |
Clint-Chester
approved these changes
May 26, 2023
|
Apologies for the delay @matsest but thank you so much for the contribution! Really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since build results will vary across versions this adds the option to
specify version. The default version is the latest available version.
This is motivated by the release cadence of Bicep versions and wanting
to test for specific or multiple versions.
Other fixes: