-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octoprint 1.9 - Bettergrbl wont work at all? #118
Comments
Seems legit, as in legit broke. I'll poke around and see what changed with 1.9 to trigger this. Basically bgs is fighting with Octoprint to get its profile loaded. Since that operation is failing, bgs is falling back thinking it's disabled. |
Ok, Thank you for poking into it :) |
Hi guys, experiencing a similar issue here. Cannot connect to my CNC machine since I updated Octoprint to 1.9.0. |
I have a fix for this I haven't committed yet. It boils down to some compatibility changes introduced in OctoPrint 1.9.0 that have caused the printer profile handler to regress. I'll push out a fix in the next day or two. In the meantime, if you want to hack around this, here's the problem. in
|
Verifying this worked and I can connect to the CNC. Some artifacts still, like the temperature tab is still there even though the setting to hide it is checked, but overall it works |
Hi Synman, Here is the Terminal content |
the fix is currently available in the dev channel https://github.com/synman/Octoprint-Bettergrblsupport/wiki/Bleeding-Edge-Updates |
Thanks for your support Synman ! |
Hi, Same issue here. I had my laser in storage for a while after moving house, just pulled it out and without thinking to check anything, allowed Octoprint to install all of the updates, now it won't connect to the laser. Atomstack A5, same error reported above. I've switched to release candidates and installed that version, but I'm having the same issue as @AlexonCNC, being that it won't save the setting for the Dev version. Could this be some permissions issue on a file? I am running a standard RPi imager install of Octoprint that has been upgraded since I first set it up early last year. Not sure where to go from here. Cheers. Edit: I managed to manually apply the updates from the workaround but the issue persists. |
Same problem here. This PlugIn doesn't work with Octoprint 1.9 anymore:
Is there any plan to fix that? |
the (manual) fix is documented in this very thread. I'll get around to fixing this properly one of these days. I agree it was a PITA due to a breaking change in the OctoPrint 1.9 release. It's even harder to undo / hop to the dev channel for the hot fix I released because it basically kills the plug-in and you can't get into it's settings to flip the switch for the dev channel. |
last, don't come here making posts about jumping to other software / etc. I don't need that kind of hate. If you're going to go away, just go away. |
It would have been nice to have received a report that a simple validation of printer profiles to make sure their values stay within sane ranges caused a breaking change for this plugin, best during the several months long release candidate phase. Finding stuff like this early is of the things the RC phase if for, and plugin authors are strongly encouraged to test their plugins against RCs so that any breaking changes can be identified and ideally resolved one way or the other BEFORE they hit users. As things are, what do you need from me here so this can get resolved? I should add that removing the validation logic again is NOT an option, as that opens up OctoPrint to issues due to corrupted/broken profiles in general. |
I didn't catch it until after 1.9 went out and decided I want to refactor my own code anyway. Life has gotten in the way sinse. I'm actually embarrassed to share the profile I was managing as it enumerated 99 nozzles (unnecessarily). Basically, I got this on my end @foosel . I just need to actually get to it. |
Gotcha. If in the end I can give you a helping hand on something after all, feel free to reach out. In the meantime, I think you would make some people happy by just providing a release with the change, and/or telling them to install the devel zip directly via the plugin manager's URL option 😉 |
Should have shared this much sooner and a special thanks to @foosel for making the suggestion for how to install my work-around version while I have the development and master branches out of sync. To work-around this issue for the time being, please go into Plug-in Manager and install Better Grbl Support using the following URL: https://github.com/synman/Octoprint-Bettergrblsupport/archive/refs/heads/devel.zip |
@synman, could it be that the devel.zip you linked no longer provides a workaround for this bug? Looking forward to using Bettergrbl! |
I just used the link and it is working. Thank you, Thank you, Thank you, Thank you, Thank you, Thank you, Thank you, |
I'm going to fix this in the main branch very soon.... possibly right now ;) |
This should now be resolved with the latest release (2.3.1). |
Describe the bug
Today I installed a fresh Octopi on my RPI3 to test Bettergrbl for my Atomstack Engraver. After installation of the plugin i noticed no changes to the UI (despite the settings being active) or any other part of octoprint to the point that not even a connection to the engraver was possible.
I reflashed three times today - each with the same result.
To Reproduce
Steps to reproduce the behavior:
Install Octopi with Octoprint 1.9, Install the plugin.
Expected behavior
The plugin should work
Screenshots
Logs
octoprint.log
serial.log
As seen in the octoprint log there is some... problem with the _bgs.profile so i checked it through SSH:
And it wont turn up on the UI:
Additional context
Cant think of any. Sorry.
The text was updated successfully, but these errors were encountered: