SYLIUS-280: missing translations and readme adds #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibbarth
reviewed
Dec 15, 2023
translations/messages.en.yaml
Outdated
| authorized_domains: Authorized domains | ||
| authorized_domains_subheader: Domain connexion management | ||
| authorized_domains: Oauth authorized domains | ||
| authorized_domains.menu_label: Oauth Domain |
There was a problem hiding this comment.
avoid use a sublevel for a defined key, you can't do anymore
app:
ui:
authorized_domains:
menu_label: blabla
There was a problem hiding this comment.
I think you misunderstood @Jibbarth 's message. The problem is that you put a translation on a key, then you created a subkey with a translation.
Perhaps change authorized_domains to authorized_domains.title ?
There was a problem hiding this comment.
it's ok, authorized_domains.title is a good choice yes
timmess
force-pushed
the
features/SYLIUS-280-missing-translations-and-readme
branch
from
4b7cfdd to
6a6a983
Compare
Jibbarth
reviewed
Dec 15, 2023
timmess
force-pushed
the
features/SYLIUS-280-missing-translations-and-readme
branch
from
6a6a983 to
bdd5208
Compare
timmess
force-pushed
the
features/SYLIUS-280-missing-translations-and-readme
branch
from
bdd5208 to
b6962f4
Compare
timmess
force-pushed
the
features/SYLIUS-280-missing-translations-and-readme
branch
2 times, most recently
from
abc8515 to
244a951
Compare
oallain
reviewed
Jan 4, 2024
timmess
force-pushed
the
features/SYLIUS-280-missing-translations-and-readme
branch
from
244a951 to
34444a2
Compare
oallain
approved these changes
Jan 4, 2024
oallain
deleted the
features/SYLIUS-280-missing-translations-and-readme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add translations and readme informations