-
Notifications
You must be signed in to change notification settings - Fork 2
fix: improve lightning payment failure messages #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
insuficient-inbound-recipient.webm
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting code review
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
Fixes #736
This PR improves Lightning payment failure error messages by parsing the
PaymentFailureReasonfrom LDK-node and displaying user-friendly, actionable messages instead of a generic "Your instant payment failed" toast.Description
Previously, all Lightning payment failures showed the same generic error message regardless of the actual cause. This made it impossible for users to understand why their payment failed or what action to take.
The PR maps
PaymentFailureReasonenum values to specific user-friendly messages:RECIPIENT_REJECTEDRETRIES_EXHAUSTEDROUTE_NOT_FOUNDPAYMENT_EXPIREDPreview
QA Notes
1. Test payment failure messages
2. Test QuickPay flow
3. Test background notifications
4. Regression