-
Notifications
You must be signed in to change notification settings - Fork 2
fix: auto-recover stale network graph cache #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review findings
…nto fix/stale-graph
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Note: This is more like a fallback. The source issue must be investigated further |
|
Testing... |
|
Relevant Logs I had to uninstall the previous app because of different signatures |
|
Succeeded on multiple attempts of 4k sats |
pwltr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
|
related LDK PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
Test results:
- Verify stale graph auto-recovery: 🟡
norepro - Verify normal startup (no stale cache): 🟢
success - Verify payment routing works by paying to Blink: 🔴
error
|
I have the feeling my issue wasn't about this, but it's good to know that this "fix" doesn't entirely resolve the "can't pay to blink" issue. |
This PR adds automatic validation and recovery for stale RGS network graph caches that cause Lightning payment routing failures.
Description
When the app uses RGS (Rapid Gossip Sync) delta updates, nodes that are missing from a stale cached graph won't be restored by incremental syncs. This caused
RouteNotFounderrors when trying to pay certain destinations like Blink wallet.validateNetworkGraph()to check if trusted peers (Blocktank LSP nodes) are present in the graphresetNetworkGraph()to delete the cached graph file when stalePreview
pay-to-blink.mp4
QA Notes
1. Verify stale graph auto-recovery
Network graph missing X trusted peersNetwork graph is stale, resetting and restarting...Network graph validated: all X trusted peers present2. Verify normal startup (no stale cache)
Network graph validated: all X trusted peers present3. Verify payment routing works
RouteNotFounderror