fix: crash in backup confirm mnemonic screen#782
Merged
Conversation
Member
Author
|
Planning do add some tests after #634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #778
This PR fixes a crash in the backup mnemonic confirmation screen that occurs when tapping a word button after all words have already been selected.
Description
When all seed words are correctly placed, tapping any remaining word button causes an
ArrayIndexOutOfBoundsException(index -1). The root cause is thatindexOfFirst { it == null }returns -1 when no slots are empty, leading to an invalid array index of -1 in the word placement logic. The fix adds an early return when all slots are filled, preventing any further word selection attempts.Preview
Screen_recording_20260213_135453.webm
QA Notes
1. Complete seed and tap extra word
2. Normal flow still works