Skip to content

Comments

Fix activity not created on send: create immediately from txid, increase LDK retries#450

Merged
ben-kaufman merged 5 commits intofeat/multiple-addresses-typesfrom
fix/activity-not-created-on-send
Feb 20, 2026
Merged

Fix activity not created on send: create immediately from txid, increase LDK retries#450
ben-kaufman merged 5 commits intofeat/multiple-addresses-typesfrom
fix/activity-not-created-on-send

Conversation

@ben-kaufman
Copy link
Contributor

Problem

Sent onchain transactions sometimes never appeared in the activity list. Logs showed:
LDK timing – onchainTransactionReceived fires ~7 seconds after broadcast.
Core queue delay – handleOnchainTransactionReceived could run 5+ minutes later due to core queue congestion.
SendSuccess polling – The success sheet polls for activity for 12 attempts (5s apart) and often times out before the activity exists.

Solution

  1. Immediate activity creation
    Create the sent onchain activity as soon as we have the txid from a successful send, instead of waiting for the LDK event:
    Added createSentOnchainActivityFromSendResult() to ActivityService to create an OnchainActivity from the send result.
    Call it from SendConfirmationView right after wallet.send() returns the txid.
    When LDK later emits onchainTransactionReceived, processOnchainPayment updates this activity (e.g. confirmation status).
  2. More retries in processOnchainTransaction
    Increased retries from 3×300ms to 10×500ms (~4.5s total) so LDK has more time to add the payment to listPayments() before we give up.

@ben-kaufman ben-kaufman marked this pull request as draft February 19, 2026 12:00
@ben-kaufman ben-kaufman force-pushed the fix/activity-not-created-on-send branch from 9c5e610 to af5093d Compare February 20, 2026 05:25
@ben-kaufman ben-kaufman changed the base branch from fix/dust-change-send-all to feat/multiple-addresses-types February 20, 2026 05:25
@ben-kaufman ben-kaufman marked this pull request as ready for review February 20, 2026 07:54
@ben-kaufman ben-kaufman merged commit 7c05c7d into feat/multiple-addresses-types Feb 20, 2026
8 checks passed
@ben-kaufman ben-kaufman deleted the fix/activity-not-created-on-send branch February 20, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant