feat: webln integration for blocktank

[pavanjoshi914]

webln integration for lightning payments.

2024-01-12.18-08-48.mp4

[BitcoinErrorLog]

Is this also working properly when Alby is disabled?

[pavanjoshi914]

Is this also working properly when Alby is disabled?

unfortunately, there is no way to detect if the wallet is disabled. alby and other lightning providers do inject providers even if it's disabled. it's just that providers won't work

[pavanjoshi914]

• are there any docs regarding how to test blocktank widget in the dev environment? do I have to spend my own sats to reach to claim channel page?

[rbndg]

We currently test internally with regtest, so we would have to merge and test it ourselves.

[rbndg]

After a review, we can merge this and we can test it internally

[pavanjoshi914]

any updates on this pr? is there anything i can help with?

[flaviomoceri]

Hi @pavanjoshi914,

I checked the code, the payment works, these are the errors:

1. Add space between "Claim Now" button and "Copy claim url" (you can use <div className={'claim-channel-button-spacer'} />)
2. Replace onClick={() => ClaimWithWebln} with onClick={ClaimWithWebln} otherwise the function is not called
3. When I try to claim the channel via Alby it doesn't seem to work (please take a look)

If you need help or have any other questions, please let me know.

I am on mainnet

recording-_3_-_1_.mp4

[pavanjoshi914]

i am not sure how i can access the claim page. is there any testnet setup you provide?

[flaviomoceri]

You can test in mainnet, currently regtest is only for internal testing

But if you use this PR and set the environment variable REACT_APP_API_URL="https://api.stag.blocktank.to/blocktank/api/v2/", you should be able to create an order in regtest and if you send me LN invoice regtest I will pay it for you, so you will be able to see the "Claim Channel" page

[pavanjoshi914]

thanks claim page might not have been working because of typo. corrected the function call should work now

[flaviomoceri]

Great, please try claiming a channel by making a video to make sure everything works

You can test on regtest by following these instructions #73 (comment), otherwise if you stay on mainnet, if you send me the LN invoice I will pay for it for you, so you can make sure that everything works

[pavanjoshi914]

unable to pay it from the regtest node

[pavanjoshi914]

if you want me to try mainnet here's my lightning address pavanj@getalby.com

[flaviomoceri]

Done, sent. Make sure to take a video please

[pavanjoshi914]

@flaviomoceri which node you use in alby. few of the connector implementations in alby doesn't support connectPeer() which is required while claiming channel. getAlby/lightning-browser-extension#3041

i created pr in wallet to show proper error when method is not supported.

not it shows proper error message

[flaviomoceri]

I currently don't have any node connected to my alby, please use your node to test, a video would be perfect

[pavanjoshi914]

#73 (comment) yup i am just clarifying the video mentioned here.

[pavanjoshi914]

do you know why the server is responding with status code 400?
here's the lnurl of created channel
lnurl1dp68gurn8ghj7cnvda3kkarpde4juumedehku7td9e6x7tmpwp5j7a3j9akz7v34xd3rqdmrxuknzve3x5kngdekxckkyvnxxuknverpxasnyerzx93kgcstylxh6

[flaviomoceri]

When do you get this error and what kind of problem are you having while trying to claim with alby?

[pavanjoshi914]

while trying to claim the channel.
lnurl decoder shows this

[SeverinAlexB]

do you know why the server is responding with status code 400? here's the lnurl of created channel lnurl1dp68gurn8ghj7cnvda3kkarpde4juumedehku7td9e6x7tmpwp5j7a3j9akz7v34xd3rqdmrxuknzve3x5kngdekxckkyvnxxuknverpxasnyerzx93kgcstylxh6

Hi @pavanjoshi914. I tested the LNURL endpoint on mainnet manually again and it works just fine for me. If you can reproduce this error again, can you show me the exact network request/response that shows the 400 error? 400 hints to a request validation issue. Maybe Alby is using LNURL slightly differently than we expect it.

Where can you find this request/response?

Developer Console -> Network -> Select the correct request -> Show me Payload, Response, and Headers/General section.

[pavanjoshi914]

i figured out alby lnurl channel implementation. found that they were missing a private field to add in lnurl callback. i updated the code and will be fixed with merging of this pr getAlby/lightning-browser-extension#3046

[pavanjoshi914]

lnurl channel fixes are merged! and will be present in the next release. please do test it. latest changes are present in alby nightly builds https://github.com/getAlby/lightning-browser-extension#try-out-the-most-recent-version-of-alby-nightly-releases

[flaviomoceri]

Great @pavanjoshi914, so have you tried claiming a channel via alby and got no errors?

[flaviomoceri]

any updates? We tried to test by connecting the node on alby but without success

[pavanjoshi914]

can you please share what error you are encountering

[MiguelMedeiros]

Hey @pavanjoshi914, thanks for your PR! 🥳

I've connected my node to my Alby extension (with nightly build) and tried to claim the channel with it.
But I got some errors! 😢

1. First try:

Nothing happend and I remebered that I needed to use the nightly build). 😄

20240308-1338-08.4794829.mp4

2. Second try:

Now with the nightly build I've tried again. Got this error:

Error: Not yet supported with the currently used account.

20240308-1343-48.1036933.mp4

3. Third try:

Tried again with the option "private channel", and got the same errror:

Error: Not yet supported with the currently used account.

20240308-1346-32.1620072.mp4

Do I need some special permissions to integrate that with my Alby account?

[pavanjoshi914]

hey @MiguelMedeiros every connector needs connectPeer function to make lnurl-channel work. unfortunately all alby connectors doesn't have that method implemented due to some issues. currently it's supported by only two connectors commando and lnd. if user has such nodes connected via alby it will work only for that.

maybe we just use webln only for payments and not lnurl channel opening for now? wdyt?

[MiguelMedeiros]

Hey @pavanjoshi914 ,

maybe we just use webln only for payments and not lnurl channel opening for now? wdyt?

Agreed, we could push the payments first, and figure it out how to claim a channel later in another PR.
All good to me! Can yo just resolve the conflicts, so we can merge it?

Thanks 🥳

[pavanjoshi914]

Thanks resolved the conflicts

[flaviomoceri]

Hi @pavanjoshi914, can you please also remove the function and button related to "Claim Channel" to be pushed in a separate PR in the future?

[pavanjoshi914]

reverted webln changes from claim page

[MiguelMedeiros]

ACK. 👍