Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hast-util-raw to the latest #37

Closed
wants to merge 1 commit into from
Closed

Conversation

revelt
Copy link

@revelt revelt commented Mar 28, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Mar 28, 2023
@wooorm
Copy link
Member

wooorm commented Mar 29, 2023

All of these problems seem to be because some tools do not respect dependencies. Some tools don’t understand ESM.
Am I correct in assuming you are working with Remix?

@wooorm
Copy link
Member

wooorm commented Mar 29, 2023

I think it’s better to switch to Raw from mdast-util-to-hast.
That’s the place that really defines Raw nodes.
hast-util-raw re-exports that now: syntax-tree/hast-util-raw@b83ec5f.
I think we can switch to that, which is better, can be a patch release as it is a fix, and will accidentally fix parse5 issues

@revelt
Copy link
Author

revelt commented Mar 29, 2023

Am I correct in assuming you are working with Remix?

My monorepo just houses npm packages, they're not related directly to remix, but the main purpose of remark-conventional-commit-changelog-timeline was indeed for my Remix website, to transform the Conventional Commit changelogs into something which can be styled nicer, in a timeline.

@revelt
Copy link
Author

revelt commented Mar 29, 2023

closing, will raise a new PR tonight late

@revelt revelt closed this Mar 29, 2023
@github-actions

This comment has been minimized.

@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Mar 29, 2023
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Mar 29, 2023
@wooorm
Copy link
Member

wooorm commented Mar 29, 2023

This will probably help: https://twitter.com/bradgarropy/status/1632589349744254976.

@revelt
Copy link
Author

revelt commented Mar 29, 2023

yeah, we need to update all unist ecosystem packages to ensure there's no parse5 v6 anywhere in the dependency trees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

2 participants