Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add positional info to attributes #11

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Add positional info to attributes #11

merged 1 commit into from
Feb 10, 2024

Conversation

appidea
Copy link
Contributor

@appidea appidea commented Feb 8, 2024 •
edited
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Adds the position data to JSX attributes. Related with #8 and mdx-js/mdx#2034

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Feb 8, 2024
remcohaszing
remcohaszing approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@wooorm wooorm changed the title feat: adds position data to JSX attributes, updates the unit tests Add positional info to attributes Feb 10, 2024
@wooorm wooorm merged commit 2b2754c into syntax-tree:main Feb 10, 2024
4 checks passed
@wooorm wooorm added the 💪 phase/solved Post is done label Feb 10, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 10, 2024
@wooorm wooorm added 🧒 semver/minor This is backwards-compatible change 🤞 phase/open Post is being triaged manually labels Feb 10, 2024
@github-actions github-actions bot removed the 💪 phase/solved Post is done label Feb 10, 2024
@wooorm
Copy link
Member

wooorm commented Feb 10, 2024

Thanks Mateusz! Released!

@wooorm wooorm added 💪 phase/solved Post is done and removed 🤞 phase/open Post is being triaged manually labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@remcohaszing remcohaszing remcohaszing approved these changes

Assignees
No one assigned
Labels
💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@appidea @wooorm @remcohaszing