Add implementation #1
Conversation
The implementation is based on `remark-break`. It was copied, then modified. The following modifications have been made: - The implementation was moved from `index.js` to `lib/index.js`. - The remark plugin was replaced with the function `newlineToBreak`. - The implementation was based on remarkjs/remark-breaks#9 (comment). - Tests are based on markdown output, not html output. This uncovered a small bug in the implementation linked above that has been fixed. - Tests are not based on a unified pipeline. - `tape` was replaced with `node:test`. - Each test fixture now has its own test case. This allows test filtering and inspecting multiple failed tests. - Dependencies were updated. - Support was dropped for Node.js < 16. - The readme was updated accordingly.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Thanks @remcohaszing!
Any ideas on why CI is running out of heap memory?
https://github.com/syntax-tree/mdast-util-newline-to-break/pull/1/checks#step:5:23
|
|
.github/workflows/main.yml
Outdated
| strategy: | ||
| matrix: | ||
| node: | ||
| - lts/hydrogen |
There was a problem hiding this comment.
Could we use the same Node-version-minimum as in remark-breaks?
That way, we can immediately migrate that project to use this, without forcing a major breaking change
There was a problem hiding this comment.
No, because I used node:test. However, I have changed it to lts/gallium.
As a side note: I constantly have to look up these names. It would be much clearer to me to use version numbers.
There was a problem hiding this comment.
I particularly meant in reply of your OP point “Support was dropped for Node.js < 16”.
I think that’s a bad idea, as it forces a major in remark-breaks.
I don’t care much for whether tools/CI use Node 14 or 16 (that is, I’d prefer not to, but node:test is great).
Using the lts/* scheme ensures lts versions are used, which is the goal with this. Numbers don’t really mean anything here. See also https://github.com/nodejs/Release/blob/main/CODENAMES.md
There was a problem hiding this comment.
I agree that they are not common. So I get that they’re not familiar to you. I quite like the channels though :(
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
Co-authored-by: Titus <tituswormer@gmail.com>
|
Ready I believe, right? |
This comment has been minimized.
This comment has been minimized.
Closes GH-1. Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com> Reviewed-by: Titus Wormer <tituswormer@gmail.com> Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Co-authored-by: Titus Wormer <tituswormer@gmail.com>
|
Oh no, I accidentally “normal ugly” merged :'( But I fixed the history 😅 |
|
Oh no! You can disable that option in the repo settings, but I guess you know, but didn’t do that yet. |
|
Yeah I did, too late haha. Thanks so much for your work, released in 💯! |
Initial checklist
Description of changes
The implementation is based on
remark-break. It was copied, then modified. The following modifications have been made:index.jstolib/index.js.newlineToBreak.mdast-util-breaksremarkjs/remark-breaks#9 (comment).tapewas replaced withnode:test.