Fix hProperties on tableCell
#71
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
🤞 phase/open
wooorm
reviewed
Aug 28, 2023
Signed-off-by: Titus <tituswormer@gmail.com>
wooorm
approved these changes
Aug 28, 2023
wooorm
changed the title
data.hProperties not working for tableCellhProperties on tableCell
This comment has been minimized.
This comment has been minimized.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
data.hPropertiesnot working for tableCellInitial checklist
Description of changes
This pull request addresses an issue where the data.hProperties property was not being properly applied to tableCell elements in the mdast-util-to-hast library. The problem originates from the loop processing of children within the table-row.js file, where the state.applyData function is being passed the parent tableRow instead of the tableCell itself.