Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #62

Merged
merged 14 commits into from
Nov 10, 2019
Merged

Add types #62

merged 14 commits into from
Nov 10, 2019

Conversation

BarryThePenguin
Copy link
Member

I wanted to see what the types would look like for mdast-util-toc

Bit of an experiment, not sure how correct it is..

I really like what unist-util-is can do with types

BarryThePenguin
BarryThePenguin commented Nov 2, 2019
View reviewed changes
types/index.d.ts Outdated Show resolved Hide resolved
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🙉 open/needs-info This needs some more info 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Nov 2, 2019
ChristianMurphy
ChristianMurphy reviewed Nov 2, 2019
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BarryThePenguin! 🙇‍♂️
Looks good. 👍
Added a few comments below. 🔎

types/index.d.ts Outdated Show resolved Hide resolved
types/tslint.json Outdated Show resolved Hide resolved
types/tsconfig.json Outdated Show resolved Hide resolved
types/mdast-util-toc-tests.ts Outdated Show resolved Hide resolved
types/tslint.json Outdated Show resolved Hide resolved
types/tslint.json Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@ChristianMurphy
Copy link
Member

/cc @Rokt33r

ChristianMurphy
ChristianMurphy reviewed Nov 2, 2019
View reviewed changes
types/index.d.ts Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
BarryThePenguin and others added 8 commits November 3, 2019 06:20
@BarryThePenguin @ChristianMurphy
Update types/index.d.ts
12c0abe 
Co-Authored-By: Christian Murphy <christian.murphy.42@gmail.com>
@BarryThePenguin @ChristianMurphy
Update types/tslint.json
4af1f9a 
Co-Authored-By: Christian Murphy <christian.murphy.42@gmail.com>
@BarryThePenguin @ChristianMurphy
Update types/index.d.ts
267dd25 
Co-Authored-By: Christian Murphy <christian.murphy.42@gmail.com>
@BarryThePenguin @ChristianMurphy
Update types/index.d.ts
7b01411 
Co-Authored-By: Christian Murphy <christian.murphy.42@gmail.com>
@BarryThePenguin
Add mdast typings
0cd5c12
@BarryThePenguin
Change config feedback
d8a75ee
@BarryThePenguin
Use mdast typings
45e0e4c
@BarryThePenguin
Add docs to TOCOptions
2f48939
@BarryThePenguin BarryThePenguin force-pushed the types/add-typescript-typings branch from fa4229b to 2f48939 Compare November 2, 2019 19:49
@BarryThePenguin
Copy link
Member Author

Thank you for the review, I learnt a lot! 📚

I added the mdast typings, I didn't think to check if they existed! After replacing them, it looked like TypeScript was still happy 🎉

ChristianMurphy
ChristianMurphy approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BarryThePenguin!
Two very minor docs suggestions and this should be good-to-go.

types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@ChristianMurphy
Copy link
Member

ChristianMurphy commented Nov 2, 2019 •
edited
Loading

🤔 something strange is going on in Travis CI
On one build it's passing on Node 10 https://travis-ci.org/syntax-tree/mdast-util-toc/jobs/606534457
On the other, it can't find xo https://travis-ci.org/syntax-tree/mdast-util-toc/jobs/606534418#L222 and fails

It might be a false positive, but it keeps appearing even after two build job restarts 🤔

@wooorm
Copy link
Member

wooorm commented Nov 3, 2019

@ChristianMurphy 🤔 something strange is going on in Travis CI

I see an error in that log’s install section: npm WARN enoent ENOENT: no such file or directory, open '/home/travis/build/syntax-tree/mdast-util-toc/node_modules/remark-stringify/package.json' 199. That leads me to think that Travis has a somehow corrupted version cached. I believe that pushing a new commit typically “fixes” it.

@ChristianMurphy
Copy link
Member

I reset the travis caches and restarted the build, that did the trick, thanks @wooorm! 🙇‍♂️

Rokt33r
Rokt33r approved these changes Nov 4, 2019
View reviewed changes
Copy link

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for late response!!

@wooorm wooorm merged commit 7a823fc into master Nov 10, 2019
@wooorm wooorm deleted the types/add-typescript-typings branch November 10, 2019 10:02
@wooorm wooorm added ⛵️ status/released and removed 🙉 open/needs-info This needs some more info labels Dec 1, 2019
@ChristianMurphy ChristianMurphy mentioned this pull request Feb 6, 2020
Closed
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@Rokt33r Rokt33r Rokt33r approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BarryThePenguin @ChristianMurphy @wooorm @Rokt33r