Skip to content

Conversation

rwe
Copy link
Contributor

@rwe rwe commented Sep 24, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

The module exported an entrypoint do-not-use-conditional-color as a way of using the module system to determine a runtime default value. However, a subpath import is more appropriate for this, because they're private and don't introduce a public entrypoint:
https://nodejs.org/api/packages.html#subpath-imports

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 24, 2023
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was what I wanted to use, but I was worried about their support.
I’ve now released import maps in a few packages and it seems to work

@wooorm wooorm changed the title use conditional internal import, not "do-not-use" export Refactor to use import map Sep 25, 2023
@wooorm wooorm merged commit 1b8ddbf into syntax-tree:main Sep 25, 2023
@wooorm wooorm added the 💪 phase/solved Post is done label Sep 25, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

2 participants