-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme.md #26
Update readme.md #26
Conversation
Hi! It seems you removed the template which we require. Here are our templates (pick the one you want to use and click *raw* to see its source): I won’t send you any further notifications about this, but I’ll keep on updating this comment, and hide it when done! Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unist-builder
is not required to use the module.
It is shown in the example, but unist-util-visit
works fine independently.
A potential ideas to help clarify this:
- add a "
unist-builder
is used here" type note to theuse
section - or update the example to use plain JSON, rather than a builder
- or something else
Thoughts? 💭
Could you answer @ChristianMurphy’s comment? |
Right, "install" shows how to install this module, "use" provides an example of this module used along side another module. For example, consider if the example was replaced with import {visit} from 'unist-util-visit'
import remark from 'remark'
const tree = remark().parse('Some _emphasis_, **importance**, and `code`.')
visit(tree, (node) => console.log(node)) this shows usage with |
For beginners, it would be helpful to have a readme part "Don't forget" with text, how to use the example from zero
|
I agree, that's one of the suggestions from #26 (review) |
If it's OK for you, I can update readme files of other projects with the same pattern. |
Changed in #27 |
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the |
Added installation of package unist-builder.
The example in readme.md file doesn't work without it.