Packaging React Components #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to build the project into a single js file (including the CSS).
We primarily need this to transpile the non-standard JSX in the react components into plain old javascript for use by other projects. Some more context on that can be found here from the folks at create-react-app.
I picked Rollup instead of Webpack to do the build mostly because the react project itself uses it and some other quality projects, like material-ui, do too. I'm sure webpack would work equally as well though.
Normally we wouldn't want to include the build in the repo here, but for now this works.
Also adds in a missing CSS file.