Fixes rare issue with weight management regression #1050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses an issue where weight could be calculated as not a number
due to a divide by zero error.
This happened when a person had successful weight management, starting at age
13 and then regressing back to their original weight trajectory. The issue
would happen when attempting to determine what percentage of the "adult"
(after age 20) part of regression had elapsed. Since the adult regression
period was less than one year, it was setting the denominator of the
equation to zero.
The fix now sets this denominator to 1, making the calculation of percentage
elapsed the fraction over age 20 that the person is at the time of the weight
measurement.
Addresses issue #1038
There are checkstyle issues currently in the master branch that this PR does not address. Those issues are fixed in PR #1047