Fixed a units problem in the Arrhenius diameter reaction model, added… #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a tutorial test that uses that model, and fixed the pressureBased tutorial's empty patch boundary problem
|
Hi All, I was working with the reacting particle diameter model and noticed a few issues with the Arrhenius model. This pull request addresses the issues, adds a tutorial test, and fixes the pressureBased tutorial as well. I was not able to update the methodology report, but the units in section 9.4.2 are not correct if the changes in this pull request are approved. Testing this should be as easy as building this branch, and running the Arrhenius and pressureBased tutorials in blastEulerFoam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a tutorial test that uses that model, and fixed the pressureBased tutorial's empty patch boundary problem