Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIFF/EXIF tags: Fix potential 32bit unsigned integer overflow #43

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

mdietsch
Copy link

...for rational type in metadata.

I ran into an issue with for example using 0.000493 secs for exposure time. This change fixes this.

@syoyo
Copy link
Owner

syoyo commented Jun 17, 2024

Thanks! Let me give some time to review the PR

@mdietsch
Copy link
Author

mdietsch commented Jun 17, 2024

This is the code-snippet I used to investigate this issue: godbolt
Line 11 lets you toggle between my fix and the original code

It may be of help

@syoyo syoyo merged commit d283cd3 into syoyo:release Jun 17, 2024
6 checks passed
@syoyo
Copy link
Owner

syoyo commented Jun 17, 2024

This is the code-snippet I used to investigate this issue: godbolt Line 11 lets you toggle between my fix and the original code

It may be of help

Thanks! It saves my time to write a test! Confirmed the code, and it works. So merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants