ReactSWFCompat now stops IE8 leaking on SWF unload

syranide · Jul 14, 2016 · 90ab856 · 90ab856
1 parent 8d41c08
commit 90ab856
Show file tree

Hide file tree

Showing 9 changed files with 38 additions and 10 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "react-swf",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "license": "MIT",
   "description": "Shockwave Flash Player component for React",
   "authors": ["Andreas Svensson <andreas@syranide.com>"],

diff --git a/npm-react-swf/compat.js b/npm-react-swf/compat.js
@@ -1,4 +1,4 @@
-/*! react-swf v1.0.4 | @syranide | MIT license */
+/*! react-swf v1.0.5 | @syranide | MIT license */
 
 'use strict';
 
@@ -52,6 +52,20 @@ ReactSWFCompat.prototype.componentDidUpdate = function() {
   ReactDOM.render(swfElement, this._container);
 };
 
+ReactSWFCompat.prototype.componentWillUnmount = function() {
+  // IE8 leaks nodes if AS3 `ExternalInterface.addCallback`-functions remain.
+  if (document.documentMode < 9) {
+    var node = this.getFPDOMNode();
+
+    // Node-methods are not enumerable in IE8, but properties are.
+    for (var key in node) {
+      if (typeof node[key] === 'function') {
+        node[key] = null;
+      }
+    }
+  }
+};
+
 ReactSWFCompat.prototype.render = function() {
   var containerProps = {
     ref: this._containerRefCallback

diff --git a/npm-react-swf/package.json b/npm-react-swf/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-swf",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "license": "MIT",
   "description": "Shockwave Flash Player component for React",
   "author": "Andreas Svensson <andreas@syranide.com>",

diff --git a/npm-react-swf/react-swf.js b/npm-react-swf/react-swf.js
@@ -1,4 +1,4 @@
-/*! react-swf v1.0.4 | @syranide | MIT license */
+/*! react-swf v1.0.5 | @syranide | MIT license */
 
 'use strict';
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-swf",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "license": "MIT",
   "description": "Shockwave Flash Player component for React",
   "author": "Andreas Svensson <andreas@syranide.com>",

diff --git a/react-swf-compat.js b/react-swf-compat.js
@@ -1,4 +1,4 @@
-/*! react-swf v1.0.4 | @syranide | MIT license */
+/*! react-swf v1.0.5 | @syranide | MIT license */
 
 (function(root, factory) {
   if (typeof define === 'function' && define.amd) {
@@ -57,6 +57,20 @@
     ReactDOM.render(swfElement, this._container);
   };
 
+  ReactSWFCompat.prototype.componentWillUnmount = function() {
+    // IE8 leaks nodes if AS3 `ExternalInterface.addCallback`-functions remain.
+    if (document.documentMode < 9) {
+      var node = this.getFPDOMNode();
+
+      // Node-methods are not enumerable in IE8, but properties are.
+      for (var key in node) {
+        if (typeof node[key] === 'function') {
+          node[key] = null;
+        }
+      }
+    }
+  };
+
   ReactSWFCompat.prototype.render = function() {
     var containerProps = {
       ref: this._containerRefCallback

diff --git a/react-swf-compat.min.js b/react-swf-compat.min.js
diff --git a/react-swf.js b/react-swf.js
@@ -1,4 +1,4 @@
-/*! react-swf v1.0.4 | @syranide | MIT license */
+/*! react-swf v1.0.5 | @syranide | MIT license */
 
 (function(root, factory) {
   if (typeof define === 'function' && define.amd) {

diff --git a/react-swf.min.js b/react-swf.min.js