Skip to content

Commit

Permalink
Remove legacy "classid", conflicts with Chrome
Browse files Browse the repository at this point in the history
  • Loading branch information
syranide committed Oct 16, 2014
1 parent 17ebc99 commit a6f6e25
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 33 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if (ReactSWF.isFPVersionSupported('10.0')) {

## Installation

#### Universal script [(minified)](//raw.githubusercontent.com/syranide/react-swf/v0.9.0/react-swf.min.js) [(source)](//raw.githubusercontent.com/syranide/react-swf/v0.9.0/react-swf.js)
#### Universal script [(minified)](//raw.githubusercontent.com/syranide/react-swf/v0.9.1/react-swf.min.js) [(source)](//raw.githubusercontent.com/syranide/react-swf/v0.9.1/react-swf.js)

```
<!-- Global module -->
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-swf",
"version": "0.9.0",
"version": "0.9.1",
"license": "MIT",
"description": "Shockwave Flash Player component for React",
"authors": ["Andreas Svensson <andreas@syranide.com>"],
Expand Down
13 changes: 5 additions & 8 deletions npm-react-swf/package.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"name": "react-swf",
"version": "0.9.0",
"author": "Andreas Svensson <andreas@syranide.com>",
"version": "0.9.1",
"license": "MIT",
"description": "Shockwave Flash Player component for React",
"author": "Andreas Svensson <andreas@syranide.com>",
"homepage": "https://github.com/syranide/react-swf",
"bugs": "https://github.com/syranide/react-swf/issues",
"license": "MIT",
"main": "npm-react-swf/react-swf.js",
"repository": {
"type": "git",
"url": "https://github.com/syranide/react-swf"
Expand All @@ -20,9 +21,5 @@
"player",
"object",
"embed"
],
"engines": {
"node": ">=0.10.0"
},
"main": "react-swf.js"
]
}
14 changes: 4 additions & 10 deletions npm-react-swf/react-swf.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! react-swf v0.9.0 | @syranide | MIT license */
/*! react-swf v0.9.1 | @syranide | MIT license */

'use strict';

Expand All @@ -12,7 +12,7 @@ var paramsSupportedByFP = {
'allowScriptAccess': 0, // always, sameDomain, never

'align': 0, // l, t, r
'base': 0, // "[url]"
'base': 0, // url
'bgcolor': 0, // #RRGGBB
'fullScreenAspectRatio': 0, // portrait, landscape
'loop': 1, // true*, false
Expand Down Expand Up @@ -213,7 +213,7 @@ var ReactSWF = React.createClass({

componentWillUnmount: function() {
// IE8 leaks nodes if AS3 ExternalInterface.addCallback-functions remain.
if (document.documentMode <= 8) {
if (document.documentMode < 9) {
var node = this.getDOMNode();

// Node-methods are not enumerable in IE8, but properties are.
Expand All @@ -235,13 +235,7 @@ var ReactSWF = React.createClass({

var objectProps = {
type: mimeTypeForFP,
// Not supported until next React release.
classID: 'clsid:d27cdb6e-ae6d-11cf-96b8-444553540000',
data: state.src,

// Temporary until React 0.12 release.
ref: null,
key: null
data: state.src
};

for (var key in props) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-swf",
"version": "0.9.0",
"version": "0.9.1",
"license": "MIT",
"description": "Shockwave Flash Player component for React",
"author": "Andreas Svensson <andreas@syranide.com>",
Expand Down
14 changes: 4 additions & 10 deletions react-swf.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*! react-swf v0.9.0 | @syranide | MIT license */
/*! react-swf v0.9.1 | @syranide | MIT license */

(function(root, factory) {
if (typeof define === 'function' && define.amd) {
Expand All @@ -21,7 +21,7 @@
'allowScriptAccess': 0, // always, sameDomain, never

'align': 0, // l, t, r
'base': 0, // "[url]"
'base': 0, // url
'bgcolor': 0, // #RRGGBB
'fullScreenAspectRatio': 0, // portrait, landscape
'loop': 1, // true*, false
Expand Down Expand Up @@ -222,7 +222,7 @@

componentWillUnmount: function() {
// IE8 leaks nodes if AS3 ExternalInterface.addCallback-functions remain.
if (document.documentMode <= 8) {
if (document.documentMode < 9) {
var node = this.getDOMNode();

// Node-methods are not enumerable in IE8, but properties are.
Expand All @@ -244,13 +244,7 @@

var objectProps = {
type: mimeTypeForFP,
// Not supported until next React release.
classID: 'clsid:d27cdb6e-ae6d-11cf-96b8-444553540000',
data: state.src,

// Temporary until React 0.12 release.
ref: null,
key: null
data: state.src
};

for (var key in props) {
Expand Down
4 changes: 2 additions & 2 deletions react-swf.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a6f6e25

Please sign in to comment.