ci: enable pyupgrade rules in ruff #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epenet
commented
Nov 12, 2024
Comment on lines
+362
to
+364
| yield ( | ||
| warning_style(gettext(base_message)) | ||
| + f" {unused_snapshots} ({path_to_file})" |
There was a problem hiding this comment.
| @@ -139,7 +139,7 @@ def __read_file_with_markers( | |||
| missing_version = True | |||
|
|
|||
| try: | |||
| with open(filepath, "r", encoding=TEXT_ENCODING, newline=None) as f: | |||
| with open(filepath, encoding=TEXT_ENCODING, newline=None) as f: | |||
There was a problem hiding this comment.
| @@ -53,7 +53,7 @@ def _read_snapshot_collection(self, snapshot_location: str) -> "SnapshotCollecti | |||
| return self.serializer_class.read_file(snapshot_location) | |||
|
|
|||
| @classmethod | |||
| @lru_cache() | |||
| @lru_cache | |||
There was a problem hiding this comment.
epenet
force-pushed
the
20241112-0834
branch
from
c6edc58
to
adcba82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 21 21
Lines 1596 1596
=======================================
Hits 1560 1560
Misses 36 36 🚨 Try these New Features:
|
epenet
force-pushed
the
20241112-0834
branch
from
adcba82
to
7fedbe9
Compare
|
Note: I think #896 can be closed when this is accepted/merged |
noahnu
approved these changes
Nov 18, 2024
|
🎉 This PR is included in version 4.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSIA, see https://docs.astral.sh/ruff/rules/#pyupgrade-up
Related Issues
Checklist
Additional Comments
Needs: