feat: add option to disable diffing #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #924 +/- ##
==========================================
+ Coverage 97.74% 97.75% +0.01%
==========================================
Files 21 21
Lines 1596 1604 +8
==========================================
+ Hits 1560 1568 +8
Misses 36 36 🚨 Try these New Features:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 62f6b7f | Previous: 8c1208d | Ratio |
|---|---|---|---|
benchmarks/test_1000x.py::test_1000x_reads |
0.7667252808720159 iter/sec (stddev: 0.12253267488025063) |
0.8003550914304741 iter/sec (stddev: 0.057265148672985905) |
1.04 |
benchmarks/test_1000x.py::test_1000x_writes |
0.7030590549720851 iter/sec (stddev: 0.17395380844166844) |
0.7749795092860265 iter/sec (stddev: 0.03690195509041565) |
1.10 |
benchmarks/test_standard.py::test_standard |
0.7510404105728492 iter/sec (stddev: 0.07141631877256495) |
0.7703735784935567 iter/sec (stddev: 0.05530831375771462) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
For extremely large snapshot files, the diff algorithm is not very efficient. Until the algorithm can be modified to work with large files, there is now a --snapshot-diff-mode=disabled flag that can be specified to disable diffing on snapshot assertion failures.
|
🎉 This PR is included in version 4.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For extremely large snapshot files, the diff algorithm is not very efficient. Until the algorithm can be modified to work with large files, there is now a --snapshot-diff-mode=disabled flag that can be specified to disable diffing on snapshot assertion failures.
Related Issues
Checklist
Additional Comments
No additional comments.