Adding email validator

[RomuloGatto]

A quick fix, related to issue #48, to fix email validation at registration

What type of PR is this?

(REQUIRED)

• bug

What this PR does / why we need it:

(REQUIRED)

• fix email validation at registration

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #48

Summary by CodeRabbit

• New Features
  • Introduced email format validation during user registration to ensure only valid email addresses are processed.
  • Added toast notifications for error messages to improve user feedback during registration.

[coderabbitai]

Walkthrough

Walkthrough

The update enhances the user registration process by implementing a validation step for email addresses in the registerUser function. A regular expression has been introduced to ensure that only valid email formats are accepted. If an invalid email is detected, an error message is triggered, preventing further registration actions.

Changes

Files	Change Summary
frontend/pages/index.vue	Added email validation in registerUser function with regex. Displays error message for invalid emails.

Assessment against linked issues

Objective	Addressed	Explanation
Registration allows non-emails in email field (#48)	✅

In the realm of code, a change so bright,
Valid emails now take their flight.
No more confusion, no more despair,
With validation, we’re better prepared! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Caution

Inline review comments failed to post

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 33ee208 and 665b3c1.

Files selected for processing (1)

• frontend/pages/index.vue (1 hunks)

Additional comments not posted (1)

frontend/pages/index.vue (1)

81-87: Sir, a review of the email validation logic is in order.

The regular expression used to validate the email addresses appears to be a common pattern and should suffice for basic email validation. However, it may not cover all valid email formats as per the official specifications. Consider using a more comprehensive regex or a dedicated library for email validation to enhance robustness.

- const emailRegex = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
+ // Consider using a more comprehensive regex or a library like validator.js for email validation
+ const emailRegex = /^[^\s@]+@[^\s@]+\.[^\s@]+$/; // This is a simple example

The error handling and user feedback via toast notification are well-implemented, ensuring a smooth user experience by providing immediate feedback on the input.

Comments failed to post (1)

frontend/pages/index.vue (1)

85-87: Consideration for user experience enhancement, Sir.

When an invalid email is detected, the function resets the loading state and halts further processing, which is excellent for preventing erroneous submissions. However, it might be beneficial to also clear the email input or highlight it to prompt the user to correct it.

  toast.error("Invalid email address");
+ // Optionally clear the email input or add a visual cue for correction
+ email.value = '';
  loading.value = false;
  return;

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  toast.error("Invalid email address");
  email.value = '';
  loading.value = false;
  return;