-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CSV export not including item notes #180
fix: CSV export not including item notes #180
Conversation
WalkthroughWalkthroughThe recent changes involve the modification of the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Inline review comments failed to post
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- backend/internal/core/services/reporting/io_sheet.go (1 hunks)
Comments failed to post (1)
backend/internal/core/services/reporting/io_sheet.go (1)
225-225: Sir, I've reviewed the modifications to the
ReadItems
method.The addition of the
Notes
field is a splendid enhancement, aligning perfectly with the objective to include item notes in the CSV exports. However, I would recommend implementing checks for null values or excessively long strings to ensure robustness and prevent any potential disruptions during the export process.The code changes are approved.
Consider adding error handling for the
Notes
field:+ if item.Notes == nil { + item.Notes = "No notes available" + }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.if item.Notes == nil { item.Notes = "No notes available" } Notes: item.Notes,
… v0.14.0@9f47d0f by renovate (#25934) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/sysadminsmedia/homebox](https://redirect.github.com/sysadminsmedia/homebox) | minor | `0.13.0` -> `0.14.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sysadminsmedia/homebox (ghcr.io/sysadminsmedia/homebox)</summary> ### [`v0.14.0`](https://redirect.github.com/sysadminsmedia/homebox/releases/tag/v0.14.0) [Compare Source](https://redirect.github.com/sysadminsmedia/homebox/compare/v0.13.0...v0.14.0) > \[!NOTE]\ > We are aware of some users having issues with the v0.12.0 -> v0.13.0 update on docker specifically, we have so far been unable to replicate the issue and as such this version does not contain a patch for it. We want to reassure you though that we are committed to getting to the bottom of that issue and fixing it, whether that be a patch release, or something that goes in a fuller release. #### Homebox Goes International (Languages) This update contains many fixes, and small resolutions, but it also contains a HUGE update in terms of making Homebox more accessible to international users. We've finally added i18n support to Homebox, allowing users to use Homebox in their own language. It's still early days, we've translated the majority of the main pages, and we continue working on it. To use translations, simply open Homebox, it's really that simple, it will use whatever the default language setting your browser is set to use. And fallback to English if your preferred language isn't yet available. If your language isn't yet available, please consider [contributing](https://translate.sysadminsmedia.com/projects/homebox/frontend/). For those that have already contributed, both those named, and those that don't have your GitHub linked in Weblate (and thus don't appear in commit messages to mention) thank you so much, we couldn't possible translate Homebox into so many languages ourselves. [![Translation status](http://translate.sysadminsmedia.com/widget/homebox/multi-auto.svg)](http://translate.sysadminsmedia.com/engage/homebox/) Additionally, we purchased the https://homebox.software domain to give Homebox a home of it's own on the internet. Which should not only make it more findable for SEO reasons, but also make it easier to remember the link to the documentation/home page. Additionally, we setup some sub-domains to redirect to various sites such as https://git.homebox.software for Github, https://discord.homebox.software to go to our Discord server, etc. #### What's Changed - Fix small typo in label discussion thread URL by [@​victorhooi](https://redirect.github.com/victorhooi) in [https://github.com/sysadminsmedia/homebox/pull/149](https://redirect.github.com/sysadminsmedia/homebox/pull/149) - Document search tips, cleanup documentation by [@​blessedbiped](https://redirect.github.com/blessedbiped) in [https://github.com/sysadminsmedia/homebox/pull/152](https://redirect.github.com/sysadminsmedia/homebox/pull/152) - Fixes to the Tools page by [@​rpavlik](https://redirect.github.com/rpavlik) in [https://github.com/sysadminsmedia/homebox/pull/154](https://redirect.github.com/sysadminsmedia/homebox/pull/154) - Adding i18n initial support by [@​tankerkiller125](https://redirect.github.com/tankerkiller125) in [https://github.com/sysadminsmedia/homebox/pull/155](https://redirect.github.com/sysadminsmedia/homebox/pull/155) - changed companyname and url to sysadminsmedia.com by [@​101br03k](https://redirect.github.com/101br03k) in [https://github.com/sysadminsmedia/homebox/pull/158](https://redirect.github.com/sysadminsmedia/homebox/pull/158) - \[LANGUAGE UPDATE] Frontend translations for Italian and German by [@​lukasitaly](https://redirect.github.com/lukasitaly) in [https://github.com/sysadminsmedia/homebox/pull/170](https://redirect.github.com/sysadminsmedia/homebox/pull/170) - Adding email validator by [@​RomuloGatto](https://redirect.github.com/RomuloGatto) in [https://github.com/sysadminsmedia/homebox/pull/178](https://redirect.github.com/sysadminsmedia/homebox/pull/178) - fix: CSV export not including item notes by [@​LarssonOliver](https://redirect.github.com/LarssonOliver) in [https://github.com/sysadminsmedia/homebox/pull/180](https://redirect.github.com/sysadminsmedia/homebox/pull/180) - added the ability to add a photo in the item creation modal by [@​cjmielke](https://redirect.github.com/cjmielke) in [https://github.com/sysadminsmedia/homebox/pull/173](https://redirect.github.com/sysadminsmedia/homebox/pull/173) #### New Contributors - [@​victorhooi](https://redirect.github.com/victorhooi) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/149](https://redirect.github.com/sysadminsmedia/homebox/pull/149) - [@​blessedbiped](https://redirect.github.com/blessedbiped) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/152](https://redirect.github.com/sysadminsmedia/homebox/pull/152) - [@​rpavlik](https://redirect.github.com/rpavlik) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/154](https://redirect.github.com/sysadminsmedia/homebox/pull/154) - [@​lukasitaly](https://redirect.github.com/lukasitaly) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/170](https://redirect.github.com/sysadminsmedia/homebox/pull/170) - [@​RomuloGatto](https://redirect.github.com/RomuloGatto) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/178](https://redirect.github.com/sysadminsmedia/homebox/pull/178) - [@​LarssonOliver](https://redirect.github.com/LarssonOliver) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/180](https://redirect.github.com/sysadminsmedia/homebox/pull/180) - [@​cjmielke](https://redirect.github.com/cjmielke) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/173](https://redirect.github.com/sysadminsmedia/homebox/pull/173) #### Translation Contributors Please note, this list is based on Github Commits from Weblate, it may not be 100% accurate, or contain all contributors. - [@​SKNTim](https://redirect.github.com/SKNTim) (Chinese Traditional) - [@​olsson82](https://redirect.github.com/olsson82) (Chinese Traditional) - [@​101br03k](https://redirect.github.com/101br03k) (Chinese Traditional, Swedish, French) - [@​Jackxwb](https://redirect.github.com/Jackxwb) (Chinese Simplified) - [@​SodaSyrup](https://redirect.github.com/SodaSyrup) (Turkish) - [@​N0namenull](https://redirect.github.com/N0namenull) (Russian) - [@​scyllaL](https://redirect.github.com/scyllaL) (Russian) - [@​Slydite4](https://redirect.github.com/Slydite4) (Spanish) - [@​HydrelioxGitHub](https://redirect.github.com/HydrelioxGitHub) (French) - [@​chevdor](https://redirect.github.com/chevdor) (French) - [@​lukasitaly](https://redirect.github.com/lukasitaly) (Italian, German, French) - [@​olsson82](https://redirect.github.com/olsson82) (Swedish, German) - [@​terenc3](https://redirect.github.com/terenc3) (German) **Full Changelog**: sysadminsmedia/homebox@v0.13.0...v0.14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42Ny40IiwidXBkYXRlZEluVmVyIjoiMzguNjcuNCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Exporting to CSV left the item notes column empty. This PR fixes that issue.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
io_sheet.go
: Ensure note is included in export.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #151
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
main
and ensured bug was reproducible.Summary by CodeRabbit
New Features
ReadItems
function to include a newNotes
field, providing additional context for each item processed.Impact