-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show item is archived in more places #210
feat: show item is archived in more places #210
Conversation
WalkthroughWalkthroughThe recent changes enhance the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- frontend/components/Item/Card.vue (2 hunks)
- frontend/pages/item/[id]/index.vue (1 hunks)
Additional comments not posted (3)
frontend/components/Item/Card.vue (2)
18-25
: Visual Enhancement for Archived ItemsSir, I've noticed the addition of a tooltip for archived items, which is a splendid way to inform users of the item's status. The use of the
MdiArchive
icon with a red color is quite effective for immediate recognition. This change aligns well with the PR objectives to enhance visibility of archived items.
43-43
: Proper Icon ImportationThe importation of the
MdiArchive
icon is essential for the new feature. It appears you've correctly added the import statement at the top of the script section. Well done, sir.frontend/pages/item/[id]/index.vue (1)
179-182
: Enhanced Item Detail VisibilityMaster Stark, the addition of the "Archived" field to the item details is a commendable enhancement. It provides a clear and direct indication of the item's archival status, which should greatly aid users in understanding the state of their items without unnecessary navigation or confusion. This change is well-implemented and aligns perfectly with the objectives to improve user interface clarity regarding archived items.
… v0.14.2@e2ac4aa by renovate (#26389) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/sysadminsmedia/homebox](https://redirect.github.com/sysadminsmedia/homebox) | patch | `0.14.1` -> `0.14.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sysadminsmedia/homebox (ghcr.io/sysadminsmedia/homebox)</summary> ### [`v0.14.2`](https://redirect.github.com/sysadminsmedia/homebox/releases/tag/v0.14.2) [Compare Source](https://redirect.github.com/sysadminsmedia/homebox/compare/v0.14.1...v0.14.2) #### What's Changed - add eslint-plugin-tailwindcss by [@​tonyaellie](https://redirect.github.com/tonyaellie) in [https://github.com/sysadminsmedia/homebox/pull/199](https://redirect.github.com/sysadminsmedia/homebox/pull/199) - feat: allow the hiding of the header by [@​tankerkiller125](https://redirect.github.com/tankerkiller125) in [https://github.com/sysadminsmedia/homebox/pull/202](https://redirect.github.com/sysadminsmedia/homebox/pull/202) - Fix Registration Disabled button in login page by [@​edward-shen](https://redirect.github.com/edward-shen) in [https://github.com/sysadminsmedia/homebox/pull/203](https://redirect.github.com/sysadminsmedia/homebox/pull/203) - update links by [@​tonyaellie](https://redirect.github.com/tonyaellie) in [https://github.com/sysadminsmedia/homebox/pull/206](https://redirect.github.com/sysadminsmedia/homebox/pull/206) - refresh search on include archived change by [@​tonyaellie](https://redirect.github.com/tonyaellie) in [https://github.com/sysadminsmedia/homebox/pull/208](https://redirect.github.com/sysadminsmedia/homebox/pull/208) - feat: show item is archived in more places by [@​tonyaellie](https://redirect.github.com/tonyaellie) in [https://github.com/sysadminsmedia/homebox/pull/210](https://redirect.github.com/sysadminsmedia/homebox/pull/210) - Update Documentation: Quick Start by [@​Gabrinator](https://redirect.github.com/Gabrinator) in [https://github.com/sysadminsmedia/homebox/pull/221](https://redirect.github.com/sysadminsmedia/homebox/pull/221) - make ItemViewTable headers customisable by [@​tonyaellie](https://redirect.github.com/tonyaellie) in [https://github.com/sysadminsmedia/homebox/pull/212](https://redirect.github.com/sysadminsmedia/homebox/pull/212) - fix issue with Chinese not automatically translating properly - Added option in profile to manually change language #### New Contributors - [@​edward-shen](https://redirect.github.com/edward-shen) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/203](https://redirect.github.com/sysadminsmedia/homebox/pull/203) - [@​Gabrinator](https://redirect.github.com/Gabrinator) made their first contribution in [https://github.com/sysadminsmedia/homebox/pull/221](https://redirect.github.com/sysadminsmedia/homebox/pull/221) **Full Changelog**: sysadminsmedia/homebox@v0.14.1...v0.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43Ny44IiwidXBkYXRlZEluVmVyIjoiMzguNzcuOCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #198
Summary by CodeRabbit
New Features
Bug Fixes