Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show item is archived in more places #210

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

tonyaellie
Copy link
Collaborator

@tonyaellie tonyaellie commented Sep 8, 2024

What type of PR is this?

  • bug

What this PR does / why we need it:

  • Makes it more obvious when items are archived.

Which issue(s) this PR fixes:

Fixes #198

Summary by CodeRabbit

  • New Features

    • Introduced a tooltip indicating whether an item is archived, enhancing item status visibility.
    • Added an "Archived" field to item details, displaying "Yes" or "No" based on the item's archived status.
  • Bug Fixes

    • Adjusted layout for improved spacing of child elements in the item card component.

Copy link
Contributor

coderabbitai bot commented Sep 8, 2024

Walkthrough

Walkthrough

The recent changes enhance the Card.vue and index.vue components to clearly indicate whether an item is archived. A new tooltip with an archive icon is added to the Card.vue component, displaying conditionally based on the item's archived status. Additionally, the index.vue component now includes an "Archived" field that shows "Yes" or "No" based on the item's archived state. These modifications improve the user interface by providing clearer information regarding item statuses.

Changes

Files Change Summary
frontend/components/Item/Card.vue Added a tooltip with an archive icon that conditionally displays based on item.archived. Modified flex container layout.
frontend/pages/item/[id]/index.vue Introduced an "Archived" field that displays "Yes" or "No" based on the item's archived status.

Assessment against linked issues

Objective Addressed Explanation
Make it obvious an item is archived (#198)
Display archived status on item detail and listing pages (#198)

Poem

In the realm of code, a change so bright,
An archive icon shines, a guiding light.
With "Yes" or "No," the status is clear,
Items now speak, no need for fear.
A tooltip's grace, a layout refined,
In this UI dance, clarity we find. ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 93f13b1 and 0478241.

Files selected for processing (2)
  • frontend/components/Item/Card.vue (2 hunks)
  • frontend/pages/item/[id]/index.vue (1 hunks)
Additional comments not posted (3)
frontend/components/Item/Card.vue (2)

18-25: Visual Enhancement for Archived Items

Sir, I've noticed the addition of a tooltip for archived items, which is a splendid way to inform users of the item's status. The use of the MdiArchive icon with a red color is quite effective for immediate recognition. This change aligns well with the PR objectives to enhance visibility of archived items.


43-43: Proper Icon Importation

The importation of the MdiArchive icon is essential for the new feature. It appears you've correctly added the import statement at the top of the script section. Well done, sir.

frontend/pages/item/[id]/index.vue (1)

179-182: Enhanced Item Detail Visibility

Master Stark, the addition of the "Archived" field to the item details is a commendable enhancement. It provides a clear and direct indication of the item's archival status, which should greatly aid users in understanding the state of their items without unnecessary navigation or confusion. This change is well-implemented and aligns perfectly with the objectives to improve user interface clarity regarding archived items.

@tankerkiller125 tankerkiller125 merged commit 073aade into sysadminsmedia:main Sep 11, 2024
3 checks passed
@tonyaellie tonyaellie deleted the mark-archived-items branch September 11, 2024 15:32
truecharts-admin referenced this pull request in truecharts/public Sep 14, 2024
… v0.14.2@e2ac4aa by renovate (#26389)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/sysadminsmedia/homebox](https://redirect.github.com/sysadminsmedia/homebox)
| patch | `0.14.1` -> `0.14.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>sysadminsmedia/homebox
(ghcr.io/sysadminsmedia/homebox)</summary>

###
[`v0.14.2`](https://redirect.github.com/sysadminsmedia/homebox/releases/tag/v0.14.2)

[Compare
Source](https://redirect.github.com/sysadminsmedia/homebox/compare/v0.14.1...v0.14.2)

#### What's Changed

- add eslint-plugin-tailwindcss by
[@&#8203;tonyaellie](https://redirect.github.com/tonyaellie) in
[https://github.com/sysadminsmedia/homebox/pull/199](https://redirect.github.com/sysadminsmedia/homebox/pull/199)
- feat: allow the hiding of the header by
[@&#8203;tankerkiller125](https://redirect.github.com/tankerkiller125)
in
[https://github.com/sysadminsmedia/homebox/pull/202](https://redirect.github.com/sysadminsmedia/homebox/pull/202)
- Fix Registration Disabled button in login page by
[@&#8203;edward-shen](https://redirect.github.com/edward-shen) in
[https://github.com/sysadminsmedia/homebox/pull/203](https://redirect.github.com/sysadminsmedia/homebox/pull/203)
- update links by
[@&#8203;tonyaellie](https://redirect.github.com/tonyaellie) in
[https://github.com/sysadminsmedia/homebox/pull/206](https://redirect.github.com/sysadminsmedia/homebox/pull/206)
- refresh search on include archived change by
[@&#8203;tonyaellie](https://redirect.github.com/tonyaellie) in
[https://github.com/sysadminsmedia/homebox/pull/208](https://redirect.github.com/sysadminsmedia/homebox/pull/208)
- feat: show item is archived in more places by
[@&#8203;tonyaellie](https://redirect.github.com/tonyaellie) in
[https://github.com/sysadminsmedia/homebox/pull/210](https://redirect.github.com/sysadminsmedia/homebox/pull/210)
- Update Documentation: Quick Start by
[@&#8203;Gabrinator](https://redirect.github.com/Gabrinator) in
[https://github.com/sysadminsmedia/homebox/pull/221](https://redirect.github.com/sysadminsmedia/homebox/pull/221)
- make ItemViewTable headers customisable by
[@&#8203;tonyaellie](https://redirect.github.com/tonyaellie) in
[https://github.com/sysadminsmedia/homebox/pull/212](https://redirect.github.com/sysadminsmedia/homebox/pull/212)
-   fix issue with Chinese not automatically translating properly
-   Added option in profile to manually change language

#### New Contributors

- [@&#8203;edward-shen](https://redirect.github.com/edward-shen) made
their first contribution in
[https://github.com/sysadminsmedia/homebox/pull/203](https://redirect.github.com/sysadminsmedia/homebox/pull/203)
- [@&#8203;Gabrinator](https://redirect.github.com/Gabrinator) made
their first contribution in
[https://github.com/sysadminsmedia/homebox/pull/221](https://redirect.github.com/sysadminsmedia/homebox/pull/221)

**Full Changelog**:
sysadminsmedia/homebox@v0.14.1...v0.14.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43Ny44IiwidXBkYXRlZEluVmVyIjoiMzguNzcuOCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it obvious an item is archived
2 participants