show add photo button on mobile

[tonyaellie]

What type of PR is this?

(REQUIRED)

• bug

What this PR does / why we need it:

• Improves the add image button within the create item modal on mobile.

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #213
Fixes #226

Summary by CodeRabbit

• New Features

  • Improved layout and styling of the modal's action section for a better user experience.
  • Enhanced usability of the modal with updated overflow behavior, allowing for scrollbars when content exceeds the modal's dimensions.

• Bug Fixes

  • Enhanced maintainability of the file selection input by utilizing Tailwind CSS classes for styling.

[coderabbitai]

Walkthrough

Walkthrough

The modifications made to the CreateModal.vue and Modal.vue files focus on enhancing the layout and usability of the modal components. In CreateModal.vue, the action section's spacing has been improved with a bottom margin, and the file input now utilizes Tailwind CSS for visibility control. In Modal.vue, the overflow behavior has been adjusted to allow for scrolling when content exceeds the modal's dimensions, ensuring all content remains accessible.

Changes

Files	Change Summary
frontend/components/Item/CreateModal.vue	Adjusted layout and styling of the modal's action section; added bottom margin and updated file input visibility.
frontend/components/Base/Modal.vue	Changed overflow behavior from overflow-visible to overflow-auto for better content accessibility.

Poem

In the modal's realm, a change so bright,
Spacing enhanced, a visual delight.
Hidden input, neat and clean,
Tailwind's magic, a coder's dream.
With every click, the forms align,
A smoother flow, oh how divine! ✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5612be2 and 0599be6.

Files selected for processing (1)

• frontend/components/Base/Modal.vue (1 hunks)

Additional comments not posted (1)

frontend/components/Base/Modal.vue (1)

5-5: Excellent work, sir! The modification to the modal's overflow behavior is a splendid enhancement.

The change from overflow-visible to overflow-auto on the modal box is a prudent decision. It shall ensure that the content within the modal remains accessible via scrollbars when it exceeds the available space, thereby improving the user experience, particularly on mobile devices with limited screen real estate.

This alteration aligns perfectly with the objective of enhancing the functionality of the add image button within the create item modal for mobile users. It effectively addresses the issue of content overflowing the modal's boundaries, providing a more user-friendly and accessible interface.

Well done, sir! Your attention to detail and commitment to improving the user experience is commendable.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mcarbonne]

It tested it locally and it did fix the second part of the issue #226.
By also applying the patch below, it also fix the first part of the issue.

diff --git a/frontend/components/Base/Modal.vue b/frontend/components/Base/Modal.vue
index fa63a92..999eb33 100644
--- a/frontend/components/Base/Modal.vue
+++ b/frontend/components/Base/Modal.vue
@@ -1,8 +1,8 @@
 <template>
   <div class="z-[999]">
     <input :id="modalId" v-model="modal" type="checkbox" class="modal-toggle" />
-    <div class="modal modal-bottom overflow-visible sm:modal-middle">
-      <div class="modal-box relative overflow-visible">
+    <div class="modal modal-bottom sm:modal-middle">
+      <div class="modal-box relative">
         <button :for="modalId" class="btn btn-circle btn-sm absolute right-2 top-2" @click="close">✕</button>
 
         <h3 class="text-lg font-bold">

But I don't know if it's the right way to fix it.

[tonyaellie]

@mcarbonne I think this should fix that, let me know if you have any issues with it.

[mcarbonne]

@mcarbonne I think this should fix that, let me know if you have any issues with it.

Yes it does ! I tested it on both firefox and chromium.

[mcarbonne]

Sadly, I think this PR introduced a new issue :

before:

It's now very difficult to select a date (because we need to scroll to reach the button, while keeping the datepicker open).