Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windoze QT version. #180

Closed
p3yot3 opened this issue May 3, 2018 · 1 comment
Closed

Windoze QT version. #180

p3yot3 opened this issue May 3, 2018 · 1 comment

Comments

@p3yot3
Copy link

p3yot3 commented May 3, 2018

The windoze QT wallet version still displays v3.0.0.0-7d11314 on the "about" tab, even though it's the latest v3.0.1 download. Could be confusing for some.
@sidhujag
Copy link
Member

sidhujag commented May 3, 2018

this is ok

@sidhujag sidhujag closed this as completed May 3, 2018
@p3yot3 p3yot3 mentioned this issue May 4, 2018
Closed
sidhujag pushed a commit that referenced this issue Jan 28, 2021
@laanwj
Merge #180: Peer details: connection type follow-ups
450c6b0 
79a2576 doc: update ConnectionType Doxygen documentation (Jon Atack)
f3153dc gui: improve markup handling of connection type tooltip (Jon Atack)
4f09615 gui: return inbound {full, block} relay type in peer details (Jon Atack)

Pull request description:

  Three follow-ups to #163:
  - return relay type for inbound peers
  - improve markup handling in the tooltip to facilitate translations
  - update ConnectionType doxygen documentation

  ![Screenshot from 2021-01-11 08-37-44](https://user-images.githubusercontent.com/2415484/104156081-50e69300-53e0-11eb-9b0f-880cb5626d68.png)

ACKs for top commit:
  hebasto:
    re-ACK 79a2576, only suggested changes since my [previous](bitcoin-core/gui#180 (review)) review.
  jarolrod:
    ACK 79a2576, tested on macOS 11.1 with Qt 5.15.2
  laanwj:
    Code review ACK 79a2576

Tree-SHA512: 4a8d8f8bfbaefd68e8d1bf3b20d29e4a8e8cfe97b2f8d59d3a4c338a50b61de0a67d97bd8646c04bd5df5a9679c4954b9b46e7cba24bb89f4d0e44e94cf9d66c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sidhujag @p3yot3