Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registry-scanner): handle error for fips image #2149

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

hayk99
Copy link
Contributor

@hayk99 hayk99 commented Feb 10, 2025

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@hayk99 hayk99 requested review from a team as code owners February 10, 2025 17:13
@hayk99 hayk99 changed the title Fix registry scanner image fix(registry-scanner): handle error for fips image Feb 10, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/main/README.md#pull-requests

@github-actions github-actions bot dismissed their stale review February 10, 2025 17:13

All good!

Copy link
Collaborator

@dbonino dbonino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hayk99 hayk99 merged commit 4f7f204 into main Feb 11, 2025
11 checks passed
@hayk99 hayk99 deleted the fix-registry-scanner-image branch February 11, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants