fix: Solve timezone issue in ActivityAuditClientV1 #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When trying list_events() with following parameters:
I have found that I retrieve events from 2 hours ago. Note: That my country is now UTC+2
Reason
utcnow() returns a datetime without timezone:
And so when applying timestamp to it, then Python assumes your localtime, and so the 2 hours difference
Fix
So using now(), that provides the localtime, fixes the previous issue
Thanks @marojor for suggesting the fix
Tested
Tested using a real sysdig customer: