Skip to content

feat(cloudlogs): replace FolderARN variable with BucketARN #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

feat(cloudlogs): replace FolderARN variable with BucketARN #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions modules/integrations/cloud-logs/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ data "sysdig_secure_cloud_ingestion_assets" "assets" {
locals {
account_id_hash = substr(md5(data.aws_caller_identity.current.account_id), 0, 4)
role_name = "${var.name}-${random_id.suffix.hex}-${local.account_id_hash}"
bucket_arn = regex("^([^/]+)", var.folder_arn)[0]
trusted_identity = var.is_gov_cloud_onboarding ? data.sysdig_secure_trusted_cloud_identity.trusted_identity.gov_identity : data.sysdig_secure_trusted_cloud_identity.trusted_identity.identity

topic_name = split(":", var.topic_arn)[5]
Expand Down Expand Up @@ -101,8 +100,8 @@ data "aws_iam_policy_document" "cloudlogs_s3_access" {
]

resources = [
local.bucket_arn,
"${local.bucket_arn}/*"
var.bucket_arn,
"${var.bucket_arn}/*"
]
}

Expand All @@ -116,8 +115,8 @@ data "aws_iam_policy_document" "cloudlogs_s3_access" {
]

resources = [
local.bucket_arn,
"${local.bucket_arn}/*"
var.bucket_arn,
"${var.bucket_arn}/*"
]
}
}
Expand Down Expand Up @@ -171,7 +170,7 @@ resource "sysdig_secure_cloud_auth_account_component" "aws_cloud_logs" {
cloudtrailSns = {
role_name = local.role_name
topic_arn = var.topic_arn
bucket_arn = local.bucket_arn
bucket_arn = var.bucket_arn
ingested_regions = var.regions
routing_key = local.routing_key
}
Expand Down
4 changes: 2 additions & 2 deletions modules/integrations/cloud-logs/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ variable "sysdig_secure_account_id" {
description = "ID of the Sysdig Cloud Account to enable Cloud Logs integration for (in case of organization, ID of the Sysdig management account)"
}

variable "folder_arn" {
description = "(Required) The ARN of your CloudTrail Bucket Folder"
variable "bucket_arn" {
description = "(Required) The ARN of your CloudTrail Bucket"
type = string
}

Expand Down