-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support webpack 5 #98
Conversation
TODO: Determine how to retrieve failure count
…new Set interface
This reverts commit ef3582e.
This reverts commit 90b4b07.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
This reverts commit 10cfbce.
fix exit code build problem for watch return type
The `built` flag in webpack 5 is moved: webpack/webpack@eb63cf8
The `esModule` option is turned on by default in v3
I would be grateful if webpack 4 compatibility were retained in this PR, otherwise, it will be a maintenance nightmare to keep up to date both new major and old major to support users of webpack 4 and webpack 5 at the same time
I think env variable would be better, instead, no need to pollute CLI and its enough to have just short notice in the source code why it is needed. Btw, why have you decided to continue work on Webpack 5 support here, what about |
It failed my tests with very obscure error messages. I have no idea how to fix or even reproduce the issue. On the other hand, I've had a rough idea on how to fix the previous PR for a while, so I give it a try. |
Done! All tests are passing. In order to reduce the mental burden, though the implementations of the two versions are similar, I put them into different files:
I've also added two scripts in the TravisCI config to skip TypeScript/ESLint checking for unrelated files. |
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 65.87% 60.93% -4.95%
==========================================
Files 42 44 +2
Lines 1225 1349 +124
Branches 137 158 +21
==========================================
+ Hits 807 822 +15
- Misses 400 509 +109
Partials 18 18
Continue to review full report at Codecov.
|
@sodatea Awesome, thank you so much! I'm going to review the PR shortly |
@sodatea Merged your PR and published |
What's the problem this PR addresses?
Continues the work on #83
How did you fix it?
By fixing the
isBuilt
function.Other thoughts:
memory-fs
in mochapack. It stops thedevServer.writeToDisk
option from writing actual files to the disk. In the past, it's handled bywrite-file-webpack-plugin
, but the plugin is not compatible with webpack 5. Shall I add an additional option to the CLI just to fix the tests?