Add new builtin method for log rotation #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AshFungor <evgenynarkhov2@gmail.com>
|
|
@AshFungor, sorry, I did not mean to include it without modification, as I and you mentioned, that part is outdated, so it must be double-checked and corrected too. |
Signed-off-by: AshFungor evgenynarkhov2@gmail.com
|
@HofiOne, thanks for your response. I rephrased that part, so users will know that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: syslog-ng/syslog-ng#5541
The problem
Recently, starting with syslog-ng OSE version 4.10 file destinations acquired new option:
logrotate(). This PR does three things:logrotate()option usage first in enumeration of log rotate approaches@HofiOne, in the original issue you mentioned:
Which I find a bit confusing because I thought that adding
REOPENcommand was done just to avoid reloading/restarting syslog-ng. If I'm wrong here andsyslog-ng-ctl reopencannot be used instead of reload/restart, I will remove relevant change in this PR.