cmake: running unit tests #1802
Conversation
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
cmake/add_tests.cmake
Outdated
There was a problem hiding this comment.
This is going to create a lot of warning message, if there is no Criterion.
You could write a warning next to the find_package(Criterion) instead.
cmake/add_tests.cmake
Outdated
There was a problem hiding this comment.
The target should be ${ADD_UNIT_TEST_TARGET}.
lib/eventlog/CMakeLists.txt
Outdated
There was a problem hiding this comment.
There is already an ${Eventlog_INCLUDE_DIR} variable for that. (You could convert it into uppercase if you want.)
Maybe that is not in the best place.
lib/logproto/tests/CMakeLists.txt
Outdated
There was a problem hiding this comment.
New line here would be nice.
There was a problem hiding this comment.
It would be a nicer way to not hide this error, just change it back to warning with: -Wno-error=no-pointer-sign.
tests/CMakeLists.txt
Outdated
There was a problem hiding this comment.
I like your approach, but I think it would be better, if the autotools based build would use the same approach.
Could you please update the autotools compile also ?
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
modules/json/CMakeLists.txt
Outdated
modules/json/tests/CMakeLists.txt
Outdated
modules/json/tests/CMakeLists.txt
Outdated
cmake/Modules/ExternalJSONC.cmake
Outdated
There was a problem hiding this comment.
Is this related to unit tests?
If not, can you extract the changes of this file to a separate commit?
cmake/add_tests.cmake
Outdated
cmake/Modules/Findsystemd.cmake
Outdated
There was a problem hiding this comment.
Can you extract this change to a separate commit?
There was a problem hiding this comment.
I would split this commit (along with the Makefile and configure changes).
In my opinion, this is a bugfix-like patch and has nothing to do with CMake.
<package>_FIND_QUIETLY is a read_only variable, it should not be set.
Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
5 participants
Execute in parallel: make test ARGS=-j4