merge-grammar: fixing utf8 detection for python3 #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE, the tests were executed on test branch: master and test suite: functions |
In case missing/misconfigured locale settings, python3's open() and fileinput() method fails to detect encoding: see syslog-ng#1831 (comment) for details. This patch specifies the encoding type to avoid misdetection. Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
furiel
force-pushed
the
python3-and-grammar
branch
from
eff39fb to
a010e03
Compare
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
@mochrul could you please check if this patch fixes the build problem for you? |
lbudai
approved these changes
Feb 5, 2018
|
@mochrul : lgtm, but a feedback would be great from you. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case missing/misconfigured locale settings, python3's open() and
fileinput() method fails to detect encoding: see
#1831 (comment)
for details. As a result, syslog-ng cannot be compiled on some systems.
This patch specifies the encoding type to avoid misdetection.
Fixes: #1831