Fix CMake unit test compilation (no-pie) #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: László Várady <laszlo.varady@balabit.com>
Signed-off-by: László Várady <laszlo.varady@balabit.com>
Signed-off-by: László Várady <laszlo.varady@balabit.com>
|
Build SUCCESS |
Kokan
approved these changes
Jun 22, 2018
furiel
reviewed
Jun 25, 2018
| include(CheckCCompilerFlag) | ||
| check_c_compiler_flag(-no-pie NO_PIE_AVAILABLE) | ||
| if (NO_PIE_AVAILABLE) | ||
| set_property(TARGET ${ADD_UNIT_TEST_TARGET} APPEND_STRING PROPERTY LINK_FLAGS " -no-pie") |
There was a problem hiding this comment.
So in summary set_property(TARGET ${ADD_UNIT_TEST_TARGET} PROPERTY POSITION_INDEPENDENT_CODE FALSE) does not work with mac and gcc v>=6, hence the workaround. Does the POSITION_INDEPENDENT_CODE give anything after this workaround, or we could just delete that line?
There was a problem hiding this comment.
We could remove that line, it does not give anything to the tests.
However, the code below is just a workaround that we'll remove after a "few" years (:smiley:), so I would leave POSITION_INDEPENDENT_CODE here.
furiel
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a workaround for a bug in the implementation of the
POSITION_INDEPENDENT_CODEproperty (CMake).https://gitlab.kitware.com/cmake/cmake/issues/16561