Relax commit check #2807
Relax commit check #2807
Conversation
|
Build SUCCESS |
tests/commits/check.sh
Outdated
|
|
||
| subject=$(git show -s --format='%s' $commit) | ||
|
|
||
| if echo "$subject" | egrep -q '^Revert '; then | ||
| revert_commit=1 | ||
| fi |
There was a problem hiding this comment.
Do we really want the "revert" commits to be excluded ?
The revert commit does not really have any details that distinguish it from other commits (message can be altered any point).
By including the Signed-off in the commit message, does not really mean anything at all. (git at least does not specify, and I could not find any statement in the syslog-ng repository either, except that you must include in every commit)
Despite the above I like Signed-Off as you can easily give credit with it to other people.
There was a problem hiding this comment.
We have 22 revert commits in this repository, only 3 of them contain signoff lines. We can start using signoffs there too.
tests/commits/check.sh
Outdated
| @@ -40,7 +40,7 @@ git log --no-merges --pretty="%H" $commit_range -- | ( | |||
|
|
|||
| subject=$(git show -s --format='%s' $commit) | |||
|
|
|||
| if ! echo "$subject" | egrep -q '^[a-z/_-]+:'; then | |||
| if ! echo "$subject" | egrep -q '^[a-zA-Z0-9/(){}$,._-]+:'; then | |||
There was a problem hiding this comment.
I was kinda happy with the strict version, especially not to include upper case letters :) I see the value in the rest modification. As this is a very opinionated topic, it is not a change request.
MrAnno
force-pushed
the
relax-commit-check
branch
from
604415b to
8afd601
Compare
The following subjects are accepted now:
Revert "cfg-parser: add aliases for yesno"
geoip2: extend msg with ip
Light: Remove unused Light dependencies
autotools,cmake: add -Wundef
$(grep): fixed possible segfault on parse errors
elastic-v2: fixed debian packaging
network(): added grammar skeleton and plugin registration
version.sh: unset CDPATH
tests/copyright: set copyright policy for new dbld related files
dbld/images/centos{6,7}: add Python/pip support
Signed-off-by: László Várady <laszlo.varady@balabit.com>
MrAnno
force-pushed
the
relax-commit-check
branch
from
8afd601 to
cc2960d
Compare
|
Build SUCCESS |
|
I have a commit like |
|
@furiel according to this PR (see the examples): |
|
Update:
Sorry, but the "Light" starts with capital "L", I would not like change it to: "l" |
|
I personally prefer lowercase subjects, but I've added uppercase letters to the commit-checker because I don't think we should be that strict. |
|
@MrAnno Thanks for the clarification. I am approving this. |
In my opinion, the following subjects should be accepted: