Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'grave accent' (`) for SET statements parsing #3479

Closed
3 tasks done
JavierJF opened this issue Jun 11, 2021 · 0 comments · Fixed by #3480
Closed
3 tasks done

Add support for 'grave accent' (`) for SET statements parsing #3479

JavierJF opened this issue Jun 11, 2021 · 0 comments · Fixed by #3480
Assignees

Comments

@JavierJF
Copy link
Collaborator

  • A clear description of the issue

Right now whenever a SET statement is issued containing grave accents like for example:

SET `group_concat_max_len` = 2048

ProxySQL will fail to parse the query resulting into a message like:

7094:unable_to_parse_set_statement(): [WARNING] Unable to parse unknown SET query from client 127.0.0.1:53688. Setting lock_hostgroup. Please report a bug for future enhancements:SET `group_concat_max_len` = 2048

And locking the hostgroup because of it.

  • ProxySQL version

v2.2.0

  • The steps to reproduce the issue

Issue any set statements in which the variable is surrounded by grave accents. Another example:

SET SESSION `wait_timeout` = 3600

Results in:

2021-06-11 18:24:11 MySQL_Session.cpp:7094:unable_to_parse_set_statement(): [WARNING] Unable to parse unknown SET query from client 127.0.0.1:53692. Setting lock_hostgroup. Please report a bug for future enhancements:SET SESSION `wait_timeout` = 3600
@JavierJF JavierJF self-assigned this Jun 11, 2021
JavierJF added a commit that referenced this issue Jun 12, 2021
JavierJF added a commit that referenced this issue Jun 12, 2021
JavierJF added a commit that referenced this issue Jun 12, 2021
JavierJF added a commit that referenced this issue Jun 12, 2021
renecannao added a commit that referenced this issue Jun 28, 2021
Closes #3479: Add support for 'grave accent' (`) for SET statements parsing
JavierJF added a commit that referenced this issue Aug 31, 2021
JavierJF added a commit that referenced this issue Aug 31, 2021
JavierJF added a commit that referenced this issue Aug 31, 2021
JavierJF added a commit that referenced this issue Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant