Closes #3756: Conflict between deprecate_eof and fast_forward
#3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'DEPRECATE_EOF' support wasn't properly tracked in 'server_capabilities'. Because this property is used for setting 'DEPRECATE_EOF' in 'client_flags' options for backend connections when 'fast_forward' is used, a mismatch between a client and a backend connection could take place.
…nnection pool A thread local connection should be retrieved only if 'fast_forward' is disabled AND 'create_new_connection' wasn't present in the query.
|
Retest this please. |
1 similar comment
|
Retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes a issue found during development regarding
create_new_connectionquery annotation.Query annotation issue description
When query annotation 'create_new_connection` is used, the request may fail if the connection is requested from the thread local cache instead of the connection pool.