Fix mysql-auto_increment_delay_multiplex_timeout_ms - Closes #3923
#3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
1 similar comment
|
retest this please |
If any scenario is found in which we may want to consider a non 'ASYNC_IDLE' connection for expiring, this precondition shall be removed, and checks should be responsible for ensuring 'ASYNC_IDLE' state in the connection.
…and fix 'connection_delay_multiplex_ms' This commit contains an implementation rework and a fix: - Impl for 'auto_increment_delay_multiplex_timeout_ms' has been reworked in favor of reusing 'wait_until' to share logic with previous 'connection_delay_multiplex_ms' variable. - Fix previous 'connection_delay_multiplex_ms' behavior preventing connection retaining when traffic unrelated to target hostgroup is being received by the session.
…o testing 'connection_delay_multiplex_ms'
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
renecannao
changed the title
mysql-auto_increment_delay_multiplex_timeout_ms - Closes #3923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Closes #3923.