Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Admin 'HTTP_Server' and 'RESTAPI' init to end of phase3 - Closes #4510 #4518

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

JavierJF
Copy link
Collaborator

This PR fixes two issues:

  • Prevent crashes when 'HTTP_Server' or 'RESTAPI' are enabled and queried during the startup process, when modules are not fully initialized yet. This modules are now initialized after all relevant/dependent modules are fully initialized, this is, at end of 'phase3'.
  • Fix a found 'user-after-free' on the HTTP_Server.

This PR doesn't add automated testing but the following scripts were used during the manual testing of the patches:

4510-scripts.zip

…4510

Prevents invalid accesses that this modules can perform on other yet
non-initialized modules during boot process.
@JavierJF
Copy link
Collaborator Author

Retest this please.

@mirostauder
Copy link
Collaborator

retest this please.

@mirostauder
Copy link
Collaborator

retest this please

2 similar comments
@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@renecannao renecannao merged commit 8a525bf into v2.x Apr 24, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants