Skip to content

Conversation

tzuyichan
Copy link
Contributor

in the hope ... will -> in the hope that ... would
get -> got
where are ... gone -> where have ... gone
For those not -> For those who are not

in the hope ... will -> in the hope that ... would
get -> got
where are ... gone -> where have ... gone
For those not -> For those who are not
@jserv
Copy link
Contributor

jserv commented Oct 29, 2021

Can you check grammar with Grammarly and alternatives such as Trinka?

@tzuyichan
Copy link
Contributor Author

tzuyichan commented Nov 8, 2021

Sure, I just did.
Unfortunately, Grammarly and Trinka had a hard time picking up on these subtler grammar patterns. I think mixing programming terms and variables in the text also affected their accuracy.

@leewei05
Copy link

leewei05 commented Mar 23, 2022

@tzuyichan @jserv
Other than Grammarly and Trinka, we can also use Linggle or Netspeak to check if certain phrases are commonly used.
For example, we can search for the use of in the hope that.
Moreover, we can use ? or ... to find one or many words, where have ? gone

As for For those not and For those who are not, I personally think they are both correct. However, if you consider the coherence of these sentences, I would rewrite them as the following:

Original

Those familiar with shell scripts will easily be able to spot them. For those not, the obj-$(CONFIG_FOO) entries you see everywhere expand into obj-y or obj-m, depending on whether the CONFIG_FOO variable has been set to y or m.

New

Those (who are) familiar with shell scripts can easily know the answer. For those who are not, every obj-$(CONFIG_FOO) entries are expanded into obj-y or obj-m, depending on whether we set the CONFIG_FOO variable to y or m.

Because the last sentence was a question, I changed some of the wordings.

@jserv jserv merged commit b950a10 into sysprog21:master Oct 22, 2022
@jserv
Copy link
Contributor

jserv commented Oct 22, 2022

Thank @tzuyichan for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants